From mboxrd@z Thu Jan 1 00:00:00 1970 From: ethan zhao Subject: Re: [PATCH Resend] cpufreq: Set cpufreq_cpu_data to NULL before putting kobject Date: Mon, 02 Feb 2015 12:16:35 +0800 Message-ID: <54CEFA23.7040705@oracle.com> References: <54CEECF7.7020504@oracle.com> <54CEF123.5050106@oracle.com> <54CEF574.6040404@oracle.com> <54CEF7AA.80401@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from aserp1040.oracle.com ([141.146.126.69]:20947 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754892AbbBBEQ4 (ORCPT ); Sun, 1 Feb 2015 23:16:56 -0500 In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Viresh Kumar Cc: Rafael Wysocki , santosh shilimkar , Linaro Kernel Mailman List , "linux-pm@vger.kernel.org" , linux-kernel On 2015/2/2 12:09, Viresh Kumar wrote: > On 2 February 2015 at 09:36, ethan zhao wrote: >> Is that an idea it supposed to be or fact ? >> >> if (!cpufreq_suspended) >> cpufreq_policy_free(policy); >> >> static void cpufreq_policy_free(struct cpufreq_policy *policy) >> { >> free_cpumask_var(policy->related_cpus); >> free_cpumask_var(policy->cpus); >> kfree(policy); >> } >> >> It seems >> you just think about it ideally in mind. We am talking about the policy allocation and de-allocation. right ? I showed you the cpufreq_policy_free(policy) doesn't check kobject refcount as above. Hmmm, you are still sleeping in the kobject, wake up and don't mix water anymore. Thanks, Ethan > if (!cpufreq_suspended) > cpufreq_policy_put_kobj(policy); > > static void cpufreq_policy_put_kobj(struct cpufreq_policy *policy) > { > ... > > kobject_put(kobj); > > /* > * We need to make sure that the underlying kobj is > * actually not referenced anymore by anybody before we > * proceed with unloading. > */ > pr_debug("waiting for dropping of refcount\n"); > wait_for_completion(cmp); > }