From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Fu, Zhonghui" Subject: Re: [PATCH] PM-Trace: add pm-trace support for suspending phase Date: Thu, 12 Feb 2015 12:48:06 +0800 Message-ID: <54DC3086.5030603@linux.intel.com> References: <54DB6A81.3040706@linux.intel.com> <5368734.2g4GXN33HR@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5368734.2g4GXN33HR@vostro.rjw.lan> Sender: linux-kernel-owner@vger.kernel.org To: "Rafael J. Wysocki" Cc: Greg Kroah-Hartman , pavel@ucw.cz, len.brown@intel.com, linux-pm@vger.kernel.org, "linux-kernel@vger.kernel.org" List-Id: linux-pm@vger.kernel.org On 2015/2/11 23:25, Rafael J. Wysocki wrote: > On Wednesday, February 11, 2015 10:43:13 PM Fu, Zhonghui wrote: >> From 2626594c03ca3b9884dd44073385c36f99a3651d Mon Sep 17 00:00:00 2001 >> From: Zhonghui Fu >> Date: Wed, 11 Feb 2015 16:20:21 +0800 >> Subject: [PATCH] PM-Trace: add pm-trace support for suspending phase > Can you please avoid putting the above header lines into your patches? > > The only one that may be necessary is the From: line, but that's only > needed if you submit from a different address. > > Also please don't send To: mailing lists. Use CC instead. In fact, there > should be *one* address in the To: field when you're submitting a patch: > The address of the maintainer you want to apply the patch for you. Thanks for your guidance, and I will re-send this patch. > >> Occasionally, the system can't come back up after suspend/resume >> due to problems of device suspending phase. This patch make >> PM_TRACE infrastructure cover device suspending phase of >> suspend/resume process, and the information in RTC can tell >> developers which device suspending function make system hang. > Do you have any examples of when this helped and no other debug methods did? > > It seems odd to me that no one has ever asked for this for several years and > now you need it. We ever run into some system hang during suspending some devices on BayTrail-T platform such as DMA, audio, etc. So, extending PM-Trace to suspend phase should be helpful. Thanks, Zhonghui > >