From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH] cpuidle: mvebu: Fix the CPU PM notifier usage Date: Fri, 27 Feb 2015 17:50:23 +0100 Message-ID: <54F0A04F.20706@linaro.org> References: <1424971248-29076-1-git-send-email-gregory.clement@free-electrons.com> <4892716.Bf612zPN6E@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-wg0-f54.google.com ([74.125.82.54]:46366 "EHLO mail-wg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753343AbbB0Qu2 (ORCPT ); Fri, 27 Feb 2015 11:50:28 -0500 Received: by wggy19 with SMTP id y19so21490496wgg.13 for ; Fri, 27 Feb 2015 08:50:27 -0800 (PST) In-Reply-To: <4892716.Bf612zPN6E@vostro.rjw.lan> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: "Rafael J. Wysocki" , Gregory CLEMENT Cc: linux-pm@vger.kernel.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , Ezequiel Garcia , linux-arm-kernel@lists.infradead.org, Maxime Ripard , Boris BREZILLON , Lior Amsalem , Tawfik Bayouk , Nadav Haklai On 02/26/2015 10:55 PM, Rafael J. Wysocki wrote: > On Thursday, February 26, 2015 06:20:48 PM Gregory CLEMENT wrote: >> As stated in kernel/cpu_pm.c, "Platform is responsible for ensuring >> that cpu_pm_enter is not called twice on the same CPU before >> cpu_pm_exit is called.". In the current code in case of failure when >> calling mvebu_v7_cpu_suspend, the function cpu_pm_exit() is never >> called whereas cpu_pm_enter() was called just before. >> >> This patch moves the cpu_pm_exit() in order to balance the >> cpu_pm_enter() calls. >> >> Reported-by: Fulvio Benini >> Signed-off-by: Gregory CLEMENT > > Should that go to "stable" too? Which "stable" series it should go t= o if so? Hi Rafael, do you mind if I take this fix in my tree ? There is the same issue for= =20 cpuidle-arm64.c I fixed. --=20 Linaro.org =E2=94=82 Open source software fo= r ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog