Re: [PATCH V2 03/20] cpufreq: Throw warning when we try to get policy for an invalid CPU

[Saravana Kannan <skannan@codeaurora.org>]

On 02/19/2015 03:32 AM, Viresh Kumar wrote:
> Simply returning here with an error is not enough. It shouldn't be allowed at
> all to try calling cpufreq_cpu_get() for an invalid CPU.
>
> Add a WARN here to make it clear that it wouldn't be acceptable at all.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
>   drivers/cpufreq/cpufreq.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 4884caf92bff..9da8ed5bdd21 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -229,7 +229,7 @@ struct cpufreq_policy *cpufreq_cpu_get(unsigned int cpu)
>   	struct cpufreq_policy *policy = NULL;
>   	unsigned long flags;
>
> -	if (cpu >= nr_cpu_ids)
> +	if (WARN_ON(cpu >= nr_cpu_ids))
>   		return NULL;
>
>   	if (!down_read_trylock(&cpufreq_rwsem))
>

Acked-by: Saravana Kannan <skannan@codeaurora.org>

-Saravana


-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project