[PATCH 1/6] clocksource/sh_cmt.c: Fix !HAS

linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH 1/6] clocksource/sh_cmt.c: Fix !HAS_IOMEM build
@ 2015-03-16 21:27 Richard Weinberger
  2015-03-16 21:27 ` [PATCH 2/6] clocksource/sh_mtu2.c: " Richard Weinberger
                   ` (6 more replies)
  0 siblings, 7 replies; 16+ messages in thread
From: Richard Weinberger @ 2015-03-16 21:27 UTC (permalink / raw)
  To: linux-kernel
  Cc: linux-iio, linux-pm, dwmw2, dbaryshkov, sre, jassisinghbrar,
	pmeerw, lars, knaack.h, jic23, tglx, daniel.lezcano,
	Richard Weinberger

Fixes:
drivers/clocksource/sh_cmt.c: In function ‘sh_cmt_map_memory’:
drivers/clocksource/sh_cmt.c:920:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration]
  cmt->mapbase = ioremap_nocache(mem->start, resource_size(mem));
  ^
drivers/clocksource/sh_cmt.c:920:15: warning: assignment makes pointer from integer without a cast [enabled by default]
  cmt->mapbase = ioremap_nocache(mem->start, resource_size(mem));
               ^
drivers/clocksource/sh_cmt.c: In function ‘sh_cmt_setup’:
drivers/clocksource/sh_cmt.c:1034:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
  iounmap(cmt->mapbase);

Signed-off-by: Richard Weinberger <richard@nod.at>
---
 drivers/clocksource/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 68161f7..c948f4e 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -192,6 +192,7 @@ config SYS_SUPPORTS_EM_STI
 config SH_TIMER_CMT
 	bool "Renesas CMT timer driver" if COMPILE_TEST
 	depends on GENERIC_CLOCKEVENTS
+	depends on HAS_IOMEM
 	default SYS_SUPPORTS_SH_CMT
 	help
 	  This enables build of a clocksource and clockevent driver for
-- 
1.8.4.5

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 2/6] clocksource/sh_mtu2.c: Fix !HAS_IOMEM build
  2015-03-16 21:27 [PATCH 1/6] clocksource/sh_cmt.c: Fix !HAS_IOMEM build Richard Weinberger
@ 2015-03-16 21:27 ` Richard Weinberger
       [not found]   ` <1426541230-928-2-git-send-email-richard-/L3Ra7n9ekc@public.gmane.org>
  2015-03-16 21:27 ` [PATCH 3/6] clocksource/sh_tmu.c: " Richard Weinberger
                   ` (5 subsequent siblings)
  6 siblings, 1 reply; 16+ messages in thread
From: Richard Weinberger @ 2015-03-16 21:27 UTC (permalink / raw)
  To: linux-kernel
  Cc: linux-iio, linux-pm, dwmw2, dbaryshkov, sre, jassisinghbrar,
	pmeerw, lars, knaack.h, jic23, tglx, daniel.lezcano,
	Richard Weinberger

Fixes:
drivers/clocksource/sh_mtu2.c: In function ‘sh_mtu2_map_memory’:
drivers/clocksource/sh_mtu2.c:391:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration]
  mtu->mapbase = ioremap_nocache(res->start, resource_size(res));
  ^
drivers/clocksource/sh_mtu2.c:391:15: warning: assignment makes pointer from integer without a cast [enabled by default]
  mtu->mapbase = ioremap_nocache(res->start, resource_size(res));
               ^
drivers/clocksource/sh_mtu2.c: In function ‘sh_mtu2_setup’:
drivers/clocksource/sh_mtu2.c:448:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
  iounmap(mtu->mapbase);

Signed-off-by: Richard Weinberger <richard@nod.at>
---
 drivers/clocksource/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index c948f4e..c4063a6 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -202,6 +202,7 @@ config SH_TIMER_CMT
 config SH_TIMER_MTU2
 	bool "Renesas MTU2 timer driver" if COMPILE_TEST
 	depends on GENERIC_CLOCKEVENTS
+	depends on HAS_IOMEM
 	default SYS_SUPPORTS_SH_MTU2
 	help
 	  This enables build of a clockevent driver for the Multi-Function
-- 
1.8.4.5

^ permalink raw reply related	[flat|nested] 16+ messages in thread

[parent not found: <1426541230-928-2-git-send-email-richard-/L3Ra7n9ekc@public.gmane.org>]

* Re: [PATCH 2/6] clocksource/sh_mtu2.c: Fix !HAS_IOMEM build
       [not found]   ` <1426541230-928-2-git-send-email-richard-/L3Ra7n9ekc@public.gmane.org>
@ 2015-03-17  8:19     ` Geert Uytterhoeven
  2015-03-20 14:04     ` Daniel Lezcano
  1 sibling, 0 replies; 16+ messages in thread
From: Geert Uytterhoeven @ 2015-03-17  8:19 UTC (permalink / raw)
  To: Richard Weinberger
  Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-iio-u79uwXL29TY76Z2rM5mHXA, Linux PM list, David Woodhouse,
	Dmitry Eremin-Solenikov, Sebastian Reichel, Jassi Brar,
	Peter Meerwald, Lars-Peter Clausen, Hartmut Knaack,
	Jonathan Cameron, Thomas Gleixner, Daniel Lezcano

On Mon, Mar 16, 2015 at 10:27 PM, Richard Weinberger <richard-/L3Ra7n9ekc@public.gmane.org> wrote:
> Fixes:
> drivers/clocksource/sh_mtu2.c: In function ‘sh_mtu2_map_memory’:
> drivers/clocksource/sh_mtu2.c:391:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration]
>   mtu->mapbase = ioremap_nocache(res->start, resource_size(res));
>   ^
> drivers/clocksource/sh_mtu2.c:391:15: warning: assignment makes pointer from integer without a cast [enabled by default]
>   mtu->mapbase = ioremap_nocache(res->start, resource_size(res));
>                ^
> drivers/clocksource/sh_mtu2.c: In function ‘sh_mtu2_setup’:
> drivers/clocksource/sh_mtu2.c:448:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>   iounmap(mtu->mapbase);
>
> Signed-off-by: Richard Weinberger <richard-/L3Ra7n9ekc@public.gmane.org>

Acked-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 2/6] clocksource/sh_mtu2.c: Fix !HAS_IOMEM build
       [not found]   ` <1426541230-928-2-git-send-email-richard-/L3Ra7n9ekc@public.gmane.org>
  2015-03-17  8:19     ` Geert Uytterhoeven
@ 2015-03-20 14:04     ` Daniel Lezcano
  1 sibling, 0 replies; 16+ messages in thread
From: Daniel Lezcano @ 2015-03-20 14:04 UTC (permalink / raw)
  To: Richard Weinberger, linux-kernel-u79uwXL29TY76Z2rM5mHXA
  Cc: linux-iio-u79uwXL29TY76Z2rM5mHXA, linux-pm-u79uwXL29TY76Z2rM5mHXA,
	dwmw2-wEGCiKHe2LqWVfeAwA7xHQ, dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w,
	sre-DgEjT+Ai2ygdnm+yROfE0A, jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w,
	pmeerw-jW+XmwGofnusTnJN9+BGXg, lars-Qo5EllUWu/uELgA04lAiVw,
	knaack.h-Mmb7MZpHnFY, jic23-DgEjT+Ai2ygdnm+yROfE0A,
	tglx-hfZtesqFncYOwBW4kG4KsQ

On 03/16/2015 10:27 PM, Richard Weinberger wrote:
> Fixes:
> drivers/clocksource/sh_mtu2.c: In function ‘sh_mtu2_map_memory’:
> drivers/clocksource/sh_mtu2.c:391:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration]
>    mtu->mapbase = ioremap_nocache(res->start, resource_size(res));
>    ^
> drivers/clocksource/sh_mtu2.c:391:15: warning: assignment makes pointer from integer without a cast [enabled by default]
>    mtu->mapbase = ioremap_nocache(res->start, resource_size(res));
>                 ^
> drivers/clocksource/sh_mtu2.c: In function ‘sh_mtu2_setup’:
> drivers/clocksource/sh_mtu2.c:448:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>    iounmap(mtu->mapbase);
>
> Signed-off-by: Richard Weinberger <richard-/L3Ra7n9ekc@public.gmane.org>
> ---

Thanks applied to my tree for v4.0 fix.

>   drivers/clocksource/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index c948f4e..c4063a6 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -202,6 +202,7 @@ config SH_TIMER_CMT
>   config SH_TIMER_MTU2
>   	bool "Renesas MTU2 timer driver" if COMPILE_TEST
>   	depends on GENERIC_CLOCKEVENTS
> +	depends on HAS_IOMEM
>   	default SYS_SUPPORTS_SH_MTU2
>   	help
>   	  This enables build of a clockevent driver for the Multi-Function
>


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH 3/6] clocksource/sh_tmu.c: Fix !HAS_IOMEM build
  2015-03-16 21:27 [PATCH 1/6] clocksource/sh_cmt.c: Fix !HAS_IOMEM build Richard Weinberger
  2015-03-16 21:27 ` [PATCH 2/6] clocksource/sh_mtu2.c: " Richard Weinberger
@ 2015-03-16 21:27 ` Richard Weinberger
  2015-03-17  8:19   ` Geert Uytterhoeven
  2015-03-20 14:05   ` Daniel Lezcano
  2015-03-16 21:27 ` [PATCH 4/6] power/reset/rmobile-reset.c: " Richard Weinberger
                   ` (4 subsequent siblings)
  6 siblings, 2 replies; 16+ messages in thread
From: Richard Weinberger @ 2015-03-16 21:27 UTC (permalink / raw)
  To: linux-kernel
  Cc: linux-iio, linux-pm, dwmw2, dbaryshkov, sre, jassisinghbrar,
	pmeerw, lars, knaack.h, jic23, tglx, daniel.lezcano,
	Richard Weinberger

Fixes:
drivers/clocksource/sh_tmu.c: In function ‘sh_tmu_map_memory’:
drivers/clocksource/sh_tmu.c:506:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration]
  tmu->mapbase = ioremap_nocache(res->start, resource_size(res));
  ^
drivers/clocksource/sh_tmu.c:506:15: warning: assignment makes pointer from integer without a cast [enabled by default]
  tmu->mapbase = ioremap_nocache(res->start, resource_size(res));
               ^
drivers/clocksource/sh_tmu.c: In function ‘sh_tmu_setup’:
drivers/clocksource/sh_tmu.c:598:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
  iounmap(tmu->mapbase);

Signed-off-by: Richard Weinberger <richard@nod.at>
---
 drivers/clocksource/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index c4063a6..a0b036c 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -212,6 +212,7 @@ config SH_TIMER_MTU2
 config SH_TIMER_TMU
 	bool "Renesas TMU timer driver" if COMPILE_TEST
 	depends on GENERIC_CLOCKEVENTS
+	depends on HAS_IOMEM
 	default SYS_SUPPORTS_SH_TMU
 	help
 	  This enables build of a clocksource and clockevent driver for
-- 
1.8.4.5

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [PATCH 3/6] clocksource/sh_tmu.c: Fix !HAS_IOMEM build
  2015-03-16 21:27 ` [PATCH 3/6] clocksource/sh_tmu.c: " Richard Weinberger
@ 2015-03-17  8:19   ` Geert Uytterhoeven
  2015-03-20 14:05   ` Daniel Lezcano
  1 sibling, 0 replies; 16+ messages in thread
From: Geert Uytterhoeven @ 2015-03-17  8:19 UTC (permalink / raw)
  To: Richard Weinberger
  Cc: linux-kernel@vger.kernel.org, linux-iio, Linux PM list,
	David Woodhouse, Dmitry Eremin-Solenikov, Sebastian Reichel,
	Jassi Brar, Peter Meerwald, Lars-Peter Clausen, Hartmut Knaack,
	Jonathan Cameron, Thomas Gleixner, Daniel Lezcano

On Mon, Mar 16, 2015 at 10:27 PM, Richard Weinberger <richard@nod.at> wrote:
> Fixes:
> drivers/clocksource/sh_tmu.c: In function ‘sh_tmu_map_memory’:
> drivers/clocksource/sh_tmu.c:506:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration]
>   tmu->mapbase = ioremap_nocache(res->start, resource_size(res));
>   ^
> drivers/clocksource/sh_tmu.c:506:15: warning: assignment makes pointer from integer without a cast [enabled by default]
>   tmu->mapbase = ioremap_nocache(res->start, resource_size(res));
>                ^
> drivers/clocksource/sh_tmu.c: In function ‘sh_tmu_setup’:
> drivers/clocksource/sh_tmu.c:598:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>   iounmap(tmu->mapbase);
>
> Signed-off-by: Richard Weinberger <richard@nod.at>

Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 3/6] clocksource/sh_tmu.c: Fix !HAS_IOMEM build
  2015-03-16 21:27 ` [PATCH 3/6] clocksource/sh_tmu.c: " Richard Weinberger
  2015-03-17  8:19   ` Geert Uytterhoeven
@ 2015-03-20 14:05   ` Daniel Lezcano
  1 sibling, 0 replies; 16+ messages in thread
From: Daniel Lezcano @ 2015-03-20 14:05 UTC (permalink / raw)
  To: Richard Weinberger, linux-kernel
  Cc: linux-iio, linux-pm, dwmw2, dbaryshkov, sre, jassisinghbrar,
	pmeerw, lars, knaack.h, jic23, tglx

On 03/16/2015 10:27 PM, Richard Weinberger wrote:
> Fixes:
> drivers/clocksource/sh_tmu.c: In function ‘sh_tmu_map_memory’:
> drivers/clocksource/sh_tmu.c:506:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration]
>    tmu->mapbase = ioremap_nocache(res->start, resource_size(res));
>    ^
> drivers/clocksource/sh_tmu.c:506:15: warning: assignment makes pointer from integer without a cast [enabled by default]
>    tmu->mapbase = ioremap_nocache(res->start, resource_size(res));
>                 ^
> drivers/clocksource/sh_tmu.c: In function ‘sh_tmu_setup’:
> drivers/clocksource/sh_tmu.c:598:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>    iounmap(tmu->mapbase);
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---

Applied to my tree for v4.0 fix.

Thanks !

>   drivers/clocksource/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index c4063a6..a0b036c 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -212,6 +212,7 @@ config SH_TIMER_MTU2
>   config SH_TIMER_TMU
>   	bool "Renesas TMU timer driver" if COMPILE_TEST
>   	depends on GENERIC_CLOCKEVENTS
> +	depends on HAS_IOMEM
>   	default SYS_SUPPORTS_SH_TMU
>   	help
>   	  This enables build of a clocksource and clockevent driver for
>


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH 4/6] power/reset/rmobile-reset.c: Fix !HAS_IOMEM build
  2015-03-16 21:27 [PATCH 1/6] clocksource/sh_cmt.c: Fix !HAS_IOMEM build Richard Weinberger
  2015-03-16 21:27 ` [PATCH 2/6] clocksource/sh_mtu2.c: " Richard Weinberger
  2015-03-16 21:27 ` [PATCH 3/6] clocksource/sh_tmu.c: " Richard Weinberger
@ 2015-03-16 21:27 ` Richard Weinberger
  2015-03-17  8:19   ` Geert Uytterhoeven
  2015-03-20 12:31   ` Sebastian Reichel
  2015-03-16 21:27 ` [PATCH 5/6] mailbox/altera.c: " Richard Weinberger
                   ` (3 subsequent siblings)
  6 siblings, 2 replies; 16+ messages in thread
From: Richard Weinberger @ 2015-03-16 21:27 UTC (permalink / raw)
  To: linux-kernel
  Cc: linux-iio, linux-pm, dwmw2, dbaryshkov, sre, jassisinghbrar,
	pmeerw, lars, knaack.h, jic23, tglx, daniel.lezcano,
	Richard Weinberger

Fixes:
drivers/power/reset/rmobile-reset.c: In function ‘rmobile_reset_probe’:
drivers/power/reset/rmobile-reset.c:61:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
  iounmap(sysc_base2);

Signed-off-by: Richard Weinberger <richard@nod.at>
---
 drivers/power/reset/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
index 27f6646..6f791fb 100644
--- a/drivers/power/reset/Kconfig
+++ b/drivers/power/reset/Kconfig
@@ -154,6 +154,7 @@ config POWER_RESET_SYSCON
 config POWER_RESET_RMOBILE
 	tristate "Renesas R-Mobile reset driver"
 	depends on ARCH_RMOBILE || COMPILE_TEST
+	depends on HAS_IOMEM
 	help
 	  Reboot support for Renesas R-Mobile and SH-Mobile SoCs.
 
-- 
1.8.4.5

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [PATCH 4/6] power/reset/rmobile-reset.c: Fix !HAS_IOMEM build
  2015-03-16 21:27 ` [PATCH 4/6] power/reset/rmobile-reset.c: " Richard Weinberger
@ 2015-03-17  8:19   ` Geert Uytterhoeven
  2015-03-20 12:31   ` Sebastian Reichel
  1 sibling, 0 replies; 16+ messages in thread
From: Geert Uytterhoeven @ 2015-03-17  8:19 UTC (permalink / raw)
  To: Richard Weinberger
  Cc: linux-kernel@vger.kernel.org, linux-iio, Linux PM list,
	David Woodhouse, Dmitry Eremin-Solenikov, Sebastian Reichel,
	Jassi Brar, Peter Meerwald, Lars-Peter Clausen, Hartmut Knaack,
	Jonathan Cameron, Thomas Gleixner, Daniel Lezcano

On Mon, Mar 16, 2015 at 10:27 PM, Richard Weinberger <richard@nod.at> wrote:
> Fixes:
> drivers/power/reset/rmobile-reset.c: In function ‘rmobile_reset_probe’:
> drivers/power/reset/rmobile-reset.c:61:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>   iounmap(sysc_base2);
>
> Signed-off-by: Richard Weinberger <richard@nod.at>

Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 4/6] power/reset/rmobile-reset.c: Fix !HAS_IOMEM build
  2015-03-16 21:27 ` [PATCH 4/6] power/reset/rmobile-reset.c: " Richard Weinberger
  2015-03-17  8:19   ` Geert Uytterhoeven
@ 2015-03-20 12:31   ` Sebastian Reichel
  1 sibling, 0 replies; 16+ messages in thread
From: Sebastian Reichel @ 2015-03-20 12:31 UTC (permalink / raw)
  To: Richard Weinberger
  Cc: linux-kernel, linux-iio, linux-pm, dwmw2, dbaryshkov,
	jassisinghbrar, pmeerw, lars, knaack.h, jic23, tglx,
	daniel.lezcano

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

Hi Richard,

On Mon, Mar 16, 2015 at 10:27:08PM +0100, Richard Weinberger wrote:
> Fixes:
> drivers/power/reset/rmobile-reset.c: In function ‘rmobile_reset_probe’:
> drivers/power/reset/rmobile-reset.c:61:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>   iounmap(sysc_base2);
> 
> Signed-off-by: Richard Weinberger <richard@nod.at>

Thanks, applied:

http://git.infradead.org/battery-2.6.git/commit/039ab50bda5606307138b1baa1f18c7e33d357e4

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH 5/6] mailbox/altera.c: Fix !HAS_IOMEM build
  2015-03-16 21:27 [PATCH 1/6] clocksource/sh_cmt.c: Fix !HAS_IOMEM build Richard Weinberger
                   ` (2 preceding siblings ...)
  2015-03-16 21:27 ` [PATCH 4/6] power/reset/rmobile-reset.c: " Richard Weinberger
@ 2015-03-16 21:27 ` Richard Weinberger
  2015-03-16 21:27 ` [PATCH 6/6] iio/adc/cc10001_adc.c: " Richard Weinberger
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 16+ messages in thread
From: Richard Weinberger @ 2015-03-16 21:27 UTC (permalink / raw)
  To: linux-kernel
  Cc: linux-iio, linux-pm, dwmw2, dbaryshkov, sre, jassisinghbrar,
	pmeerw, lars, knaack.h, jic23, tglx, daniel.lezcano,
	Richard Weinberger

Fixes:
drivers/built-in.o: In function `altera_mbox_probe':
mailbox-altera.c:(.text+0x400196): undefined reference to `devm_ioremap_resource'

Signed-off-by: Richard Weinberger <richard@nod.at>
---
 drivers/mailbox/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
index 84325f2..81b8fb1 100644
--- a/drivers/mailbox/Kconfig
+++ b/drivers/mailbox/Kconfig
@@ -47,6 +47,7 @@ config PCC
 
 config ALTERA_MBOX
 	tristate "Altera Mailbox"
+	depends on HAS_IOMEM
 	help
 	  An implementation of the Altera Mailbox soft core. It is used
 	  to send message between processors. Say Y here if you want to use the
-- 
1.8.4.5

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 6/6] iio/adc/cc10001_adc.c: Fix !HAS_IOMEM build
  2015-03-16 21:27 [PATCH 1/6] clocksource/sh_cmt.c: Fix !HAS_IOMEM build Richard Weinberger
                   ` (3 preceding siblings ...)
  2015-03-16 21:27 ` [PATCH 5/6] mailbox/altera.c: " Richard Weinberger
@ 2015-03-16 21:27 ` Richard Weinberger
       [not found]   ` <1426541230-928-6-git-send-email-richard-/L3Ra7n9ekc@public.gmane.org>
       [not found] ` <1426541230-928-1-git-send-email-richard-/L3Ra7n9ekc@public.gmane.org>
  2015-03-20 14:05 ` Daniel Lezcano
  6 siblings, 1 reply; 16+ messages in thread
From: Richard Weinberger @ 2015-03-16 21:27 UTC (permalink / raw)
  To: linux-kernel
  Cc: linux-iio, linux-pm, dwmw2, dbaryshkov, sre, jassisinghbrar,
	pmeerw, lars, knaack.h, jic23, tglx, daniel.lezcano,
	Richard Weinberger

Fixes:
drivers/built-in.o: In function `cc10001_adc_probe':
cc10001_adc.c:(.text+0x412e92): undefined reference to `devm_ioremap_resource'

Signed-off-by: Richard Weinberger <richard@nod.at>
---
 drivers/iio/adc/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index 202daf8..46379b1 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -137,7 +137,8 @@ config AXP288_ADC
 
 config CC10001_ADC
 	tristate "Cosmic Circuits 10001 ADC driver"
-	depends on HAS_IOMEM || HAVE_CLK || REGULATOR
+	depends on HAVE_CLK || REGULATOR
+	depends on HAS_IOMEM
 	select IIO_BUFFER
 	select IIO_TRIGGERED_BUFFER
 	help
-- 
1.8.4.5

^ permalink raw reply related	[flat|nested] 16+ messages in thread

[parent not found: <1426541230-928-6-git-send-email-richard-/L3Ra7n9ekc@public.gmane.org>]

* Re: [PATCH 6/6] iio/adc/cc10001_adc.c: Fix !HAS_IOMEM build
       [not found]   ` <1426541230-928-6-git-send-email-richard-/L3Ra7n9ekc@public.gmane.org>
@ 2015-03-21 11:35     ` Jonathan Cameron
       [not found]       ` <550D5772.2010400-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
  0 siblings, 1 reply; 16+ messages in thread
From: Jonathan Cameron @ 2015-03-21 11:35 UTC (permalink / raw)
  To: Richard Weinberger, linux-kernel-u79uwXL29TY76Z2rM5mHXA
  Cc: linux-iio-u79uwXL29TY76Z2rM5mHXA, linux-pm-u79uwXL29TY76Z2rM5mHXA,
	dwmw2-wEGCiKHe2LqWVfeAwA7xHQ, dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w,
	sre-DgEjT+Ai2ygdnm+yROfE0A, jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w,
	pmeerw-jW+XmwGofnusTnJN9+BGXg, lars-Qo5EllUWu/uELgA04lAiVw,
	knaack.h-Mmb7MZpHnFY, tglx-hfZtesqFncYOwBW4kG4KsQ,
	daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A

On 16/03/15 21:27, Richard Weinberger wrote:
> Fixes:
> drivers/built-in.o: In function `cc10001_adc_probe':
> cc10001_adc.c:(.text+0x412e92): undefined reference to `devm_ioremap_resource'
> 
> Signed-off-by: Richard Weinberger <richard-/L3Ra7n9ekc@public.gmane.org>
Applied to the fixes-togreg branch of iio.git.
Won't push this out for a day or so as waiting for Greg to pull the previous set.
> ---
>  drivers/iio/adc/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 202daf8..46379b1 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -137,7 +137,8 @@ config AXP288_ADC
>  
>  config CC10001_ADC
>  	tristate "Cosmic Circuits 10001 ADC driver"
> -	depends on HAS_IOMEM || HAVE_CLK || REGULATOR
> +	depends on HAVE_CLK || REGULATOR
> +	depends on HAS_IOMEM
>  	select IIO_BUFFER
>  	select IIO_TRIGGERED_BUFFER
>  	help
> 

^ permalink raw reply	[flat|nested] 16+ messages in thread

[parent not found: <550D5772.2010400-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

* Re: [PATCH 6/6] iio/adc/cc10001_adc.c: Fix !HAS_IOMEM build
       [not found]       ` <550D5772.2010400-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
@ 2015-03-30 19:40         ` Jonathan Cameron
  0 siblings, 0 replies; 16+ messages in thread
From: Jonathan Cameron @ 2015-03-30 19:40 UTC (permalink / raw)
  To: Richard Weinberger, linux-kernel-u79uwXL29TY76Z2rM5mHXA
  Cc: linux-iio-u79uwXL29TY76Z2rM5mHXA, linux-pm-u79uwXL29TY76Z2rM5mHXA,
	dwmw2-wEGCiKHe2LqWVfeAwA7xHQ, dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w,
	sre-DgEjT+Ai2ygdnm+yROfE0A, jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w,
	pmeerw-jW+XmwGofnusTnJN9+BGXg, lars-Qo5EllUWu/uELgA04lAiVw,
	knaack.h-Mmb7MZpHnFY, tglx-hfZtesqFncYOwBW4kG4KsQ,
	daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A

On 21/03/15 11:35, Jonathan Cameron wrote:
> On 16/03/15 21:27, Richard Weinberger wrote:
>> Fixes:
>> drivers/built-in.o: In function `cc10001_adc_probe':
>> cc10001_adc.c:(.text+0x412e92): undefined reference to `devm_ioremap_resource'
>>
>> Signed-off-by: Richard Weinberger <richard-/L3Ra7n9ekc@public.gmane.org>
> Applied to the fixes-togreg branch of iio.git.
> Won't push this out for a day or so as waiting for Greg to pull the previous set.
>> ---
>>  drivers/iio/adc/Kconfig | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
>> index 202daf8..46379b1 100644
>> --- a/drivers/iio/adc/Kconfig
>> +++ b/drivers/iio/adc/Kconfig
>> @@ -137,7 +137,8 @@ config AXP288_ADC
>>  
>>  config CC10001_ADC
>>  	tristate "Cosmic Circuits 10001 ADC driver"
>> -	depends on HAS_IOMEM || HAVE_CLK || REGULATOR
>> +	depends on HAVE_CLK || REGULATOR
>> +	depends on HAS_IOMEM
>>  	select IIO_BUFFER
>>  	select IIO_TRIGGERED_BUFFER
>>  	help
>>
Hmm. Just noticed this whilst sending the pull request.  That
HAVE_CLK || REGULATOR also seems rather implausible!

> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 16+ messages in thread

[parent not found: <1426541230-928-1-git-send-email-richard-/L3Ra7n9ekc@public.gmane.org>]

* Re: [PATCH 1/6] clocksource/sh_cmt.c: Fix !HAS_IOMEM build
       [not found] ` <1426541230-928-1-git-send-email-richard-/L3Ra7n9ekc@public.gmane.org>
@ 2015-03-17  8:18   ` Geert Uytterhoeven
  0 siblings, 0 replies; 16+ messages in thread
From: Geert Uytterhoeven @ 2015-03-17  8:18 UTC (permalink / raw)
  To: Richard Weinberger
  Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-iio-u79uwXL29TY76Z2rM5mHXA, Linux PM list, David Woodhouse,
	Dmitry Eremin-Solenikov, Sebastian Reichel, Jassi Brar,
	Peter Meerwald, Lars-Peter Clausen, Hartmut Knaack,
	Jonathan Cameron, Thomas Gleixner, Daniel Lezcano

On Mon, Mar 16, 2015 at 10:27 PM, Richard Weinberger <richard-/L3Ra7n9ekc@public.gmane.org> wrote:
> Fixes:
> drivers/clocksource/sh_cmt.c: In function ‘sh_cmt_map_memory’:
> drivers/clocksource/sh_cmt.c:920:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration]
>   cmt->mapbase = ioremap_nocache(mem->start, resource_size(mem));
>   ^
> drivers/clocksource/sh_cmt.c:920:15: warning: assignment makes pointer from integer without a cast [enabled by default]
>   cmt->mapbase = ioremap_nocache(mem->start, resource_size(mem));
>                ^
> drivers/clocksource/sh_cmt.c: In function ‘sh_cmt_setup’:
> drivers/clocksource/sh_cmt.c:1034:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>   iounmap(cmt->mapbase);
>
> Signed-off-by: Richard Weinberger <richard-/L3Ra7n9ekc@public.gmane.org>

Acked-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 1/6] clocksource/sh_cmt.c: Fix !HAS_IOMEM build
  2015-03-16 21:27 [PATCH 1/6] clocksource/sh_cmt.c: Fix !HAS_IOMEM build Richard Weinberger
                   ` (5 preceding siblings ...)
       [not found] ` <1426541230-928-1-git-send-email-richard-/L3Ra7n9ekc@public.gmane.org>
@ 2015-03-20 14:05 ` Daniel Lezcano
  6 siblings, 0 replies; 16+ messages in thread
From: Daniel Lezcano @ 2015-03-20 14:05 UTC (permalink / raw)
  To: Richard Weinberger, linux-kernel
  Cc: linux-iio, linux-pm, dwmw2, dbaryshkov, sre, jassisinghbrar,
	pmeerw, lars, knaack.h, jic23, tglx

On 03/16/2015 10:27 PM, Richard Weinberger wrote:
> Fixes:
> drivers/clocksource/sh_cmt.c: In function ‘sh_cmt_map_memory’:
> drivers/clocksource/sh_cmt.c:920:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration]
>    cmt->mapbase = ioremap_nocache(mem->start, resource_size(mem));
>    ^
> drivers/clocksource/sh_cmt.c:920:15: warning: assignment makes pointer from integer without a cast [enabled by default]
>    cmt->mapbase = ioremap_nocache(mem->start, resource_size(mem));
>                 ^
> drivers/clocksource/sh_cmt.c: In function ‘sh_cmt_setup’:
> drivers/clocksource/sh_cmt.c:1034:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>    iounmap(cmt->mapbase);
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---

Applied to my tree for v4.0 fix.

Thanks !


>   drivers/clocksource/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 68161f7..c948f4e 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -192,6 +192,7 @@ config SYS_SUPPORTS_EM_STI
>   config SH_TIMER_CMT
>   	bool "Renesas CMT timer driver" if COMPILE_TEST
>   	depends on GENERIC_CLOCKEVENTS
> +	depends on HAS_IOMEM
>   	default SYS_SUPPORTS_SH_CMT
>   	help
>   	  This enables build of a clocksource and clockevent driver for
>


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2015-03-30 19:40 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-16 21:27 [PATCH 1/6] clocksource/sh_cmt.c: Fix !HAS_IOMEM build Richard Weinberger
2015-03-16 21:27 ` [PATCH 2/6] clocksource/sh_mtu2.c: " Richard Weinberger
     [not found]   ` <1426541230-928-2-git-send-email-richard-/L3Ra7n9ekc@public.gmane.org>
2015-03-17  8:19     ` Geert Uytterhoeven
2015-03-20 14:04     ` Daniel Lezcano
2015-03-16 21:27 ` [PATCH 3/6] clocksource/sh_tmu.c: " Richard Weinberger
2015-03-17  8:19   ` Geert Uytterhoeven
2015-03-20 14:05   ` Daniel Lezcano
2015-03-16 21:27 ` [PATCH 4/6] power/reset/rmobile-reset.c: " Richard Weinberger
2015-03-17  8:19   ` Geert Uytterhoeven
2015-03-20 12:31   ` Sebastian Reichel
2015-03-16 21:27 ` [PATCH 5/6] mailbox/altera.c: " Richard Weinberger
2015-03-16 21:27 ` [PATCH 6/6] iio/adc/cc10001_adc.c: " Richard Weinberger
     [not found]   ` <1426541230-928-6-git-send-email-richard-/L3Ra7n9ekc@public.gmane.org>
2015-03-21 11:35     ` Jonathan Cameron
     [not found]       ` <550D5772.2010400-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-03-30 19:40         ` Jonathan Cameron
     [not found] ` <1426541230-928-1-git-send-email-richard-/L3Ra7n9ekc@public.gmane.org>
2015-03-17  8:18   ` [PATCH 1/6] clocksource/sh_cmt.c: " Geert Uytterhoeven
2015-03-20 14:05 ` Daniel Lezcano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).