From mboxrd@z Thu Jan 1 00:00:00 1970 From: Beomho Seo Subject: Re: [PATCH v7 3/5] power: max77843_battery: Add Max77843 fuel gauge device driver Date: Tue, 24 Mar 2015 17:02:30 +0900 Message-ID: <55111A16.4090800@samsung.com> References: <1425291038-18269-1-git-send-email-jaewon02.kim@samsung.com> <1425291038-18269-4-git-send-email-jaewon02.kim@samsung.com> <20150307201426.GG5233@earth> <54FCEB17.70809@samsung.com> <54FEF52E.7060409@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.samsung.com ([203.254.224.34]:28577 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752275AbbCXICd (ORCPT ); Tue, 24 Mar 2015 04:02:33 -0400 In-reply-to: <54FEF52E.7060409@samsung.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Krzysztof Kozlowski Cc: Lee Jones , Sebastian Reichel , Jaewon Kim , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-input@vger.kernel.org, Inki Dae , SangBae Lee , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Chanwoo Choi , Dmitry Torokhov On 03/10/2015 10:44 PM, Beomho Seo wrote: > On 03/09/2015 07:01 PM, Krzysztof Kozlowski wrote: >> 2015-03-09 1:36 GMT+01:00 Beomho Seo : >>> On 03/08/2015 05:14 AM, Sebastian Reichel wrote: >>>> Hi, >>>> >>>> On Mon, Mar 02, 2015 at 07:10:36PM +0900, Jaewon Kim wrote: >>>>> From: Beomho Seo >>>>> >>>>> This patch adds device driver of max77843 fuel gauge. >>>>> The driver support for battery fuel gauge in Maxim Max77843. >>>>> It is fuel-gauge systems for lithuum-ion batteries in handled and >>>>> portable devices. >>>>> >>>>> Cc: Sebastian Reichel >>>>> Signed-off-by: Beomho Seo >>>> >>>> Reviewed-By: Sebastian Reichel >>>> >>>> I can't take it as is, since it depends on the private header file >>>> of PATCH 1. >>>> >>>> -- Sebastian >>>> >>> >>> This patch reviewed by Sebastian. >>> Could you Please merge that your git tree ? >> >> Hi, >> >> Sorry for late response, but I finally got some time to look at this. >> This driver looks very similar to max17042_battery.c fuel gauge >> driver. Obtaining some properties looks exactly the same. The >> difference seems to be in new properties. The I2C address is the same. >> >> I highly recommend to extend the max17042 driver instead. It already >> supports also max17047, max17050 and max77693. >> >> Best regards, >> Krzysztof >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-pm" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > > OK. I will follow your opinion about fuel gauge. I will extend the max17042 driver. > After test on my board, I will send a new patch set. > > Best regards, > Beomho Seo Krzysztof, gentle ping? I will extend the max17042 driver. Best regards, Beomho Seo