From: Beomho Seo <beomho.seo@samsung.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: linux-pm@vger.kernel.org,
"Krzysztof Kozlowski" <k.kozlowski@samsung.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
'대인기' <inki.dae@samsung.com>
Subject: Re: [PATCH 1/3] power: max17042_battery: Use reg type instead of chip type
Date: Wed, 01 Apr 2015 09:03:14 +0900 [thread overview]
Message-ID: <551B35C2.6070207@samsung.com> (raw)
In-Reply-To: <20150331153155.GA25737@earth>
On 04/01/2015 12:31 AM, Sebastian Reichel wrote:
> Hi,
>
> On Tue, Mar 31, 2015 at 10:34:05PM +0900, Beomho Seo wrote:
>> [...]
>> case POWER_SUPPLY_PROP_VOLTAGE_MIN_DESIGN:
>> - if (chip->chip_type == MAX17042)
>> + if (chip->reg_type == MAXIM_REG_TYPE_MAX17047)
>> ret = regmap_read(map, MAX17042_V_empty, &data);
>> else
>> ret = regmap_read(map, MAX17047_V_empty, &data);
>
> Looks like you inverted the logic.
>
>> [...]
>
> -- Sebastian
>
OK I will fix it.
Thank you for comment.
Best regards,
Beomho Seo
next prev parent reply other threads:[~2015-04-01 0:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 13:34 [PATCH 0/3] power: max17042-battery: Modify max17042 battery driver Beomho Seo
2015-03-31 13:34 ` [PATCH 1/3] power: max17042_battery: Use reg type instead of chip type Beomho Seo
2015-03-31 15:31 ` Sebastian Reichel
2015-04-01 0:03 ` Beomho Seo [this message]
[not found] <1427808574-19397-1-git-send-email-beomho.seo@samsung.com>
[not found] ` <1427808574-19397-2-git-send-email-beomho.seo@samsung.com>
2015-04-01 8:18 ` Krzysztof Kozlowski
2015-04-01 9:00 ` Beomho Seo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551B35C2.6070207@samsung.com \
--to=beomho.seo@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=inki.dae@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).