From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: rjw@rjwysocki.net, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, nicolas.pitre@linaro.org
Subject: Re: [PATCH 1/3] cpuidle: Store the idle start time stamp
Date: Wed, 15 Apr 2015 14:29:06 +0200 [thread overview]
Message-ID: <552E5992.2050404@linaro.org> (raw)
In-Reply-To: <20150415102057.GR5029@twins.programming.kicks-ass.net>
On 04/15/2015 12:20 PM, Peter Zijlstra wrote:
> On Wed, Apr 15, 2015 at 12:00:22PM +0200, Daniel Lezcano wrote:
>> + target_state->idle_stamp = ktime_to_us(ktime_get());
>
> ktime_get_ns();
>
Hmm, sounds like I missed we are dealing with different units (us / ns)
in cpuidle / sched.
Would it make sense to store the time into a ktime structure instead and
use the relevant function depending on the place we are inspecting the
value from ?
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2015-04-15 12:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 10:00 [PATCH 1/3] cpuidle: Store the idle start time stamp Daniel Lezcano
2015-04-15 10:00 ` [PATCH 2/3] cpuidle: Add some comments in the cpuidle_enter function Daniel Lezcano
2015-04-15 13:46 ` Rafael J. Wysocki
2015-04-15 16:07 ` Daniel Lezcano
2015-04-15 10:00 ` [PATCH 3/3] sched: fair: Fix wrong idle timestamp usage Daniel Lezcano
2015-04-15 12:18 ` Peter Zijlstra
2015-04-15 15:43 ` Daniel Lezcano
2015-04-15 16:02 ` Peter Zijlstra
2015-05-07 15:31 ` Daniel Lezcano
2015-04-15 17:10 ` Morten Rasmussen
2015-04-16 8:46 ` Daniel Lezcano
2015-04-15 10:20 ` [PATCH 1/3] cpuidle: Store the idle start time stamp Peter Zijlstra
2015-04-15 12:29 ` Daniel Lezcano [this message]
2015-04-15 12:42 ` Peter Zijlstra
2015-04-15 12:50 ` Daniel Lezcano
2015-04-15 13:11 ` Peter Zijlstra
2015-04-15 10:25 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552E5992.2050404@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).