From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Grygorii.Strashko@linaro.org" Subject: Re: [PATCH] mmc: core: add missing pm event in mmc_pm_notify to fix hib restore Date: Fri, 24 Apr 2015 13:52:15 +0300 Message-ID: <553A205F.6020608@linaro.org> References: <1429785823-16939-1-git-send-email-grygorii.strashko@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-la0-f52.google.com ([209.85.215.52]:35038 "EHLO mail-la0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754086AbbDXKwV (ORCPT ); Fri, 24 Apr 2015 06:52:21 -0400 Received: by labbd9 with SMTP id bd9so32338744lab.2 for ; Fri, 24 Apr 2015 03:52:20 -0700 (PDT) In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Ulf Hansson , Grygorii Strashko Cc: Sumit Semwal , linux-mmc , Kevin Hilman , "linux-pm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-omap On 04/23/2015 04:19 PM, Ulf Hansson wrote: > On 23 April 2015 at 12:43, wrote: >> From: Grygorii Strashko >> >> The PM_RESTORE_PREPARE is not handled now in mmc_pm_notify(), >> as result mmc_rescan() could be scheduled and executed at >> late hibernation restore stages when MMC device is suspended >> already - which, in turn, will lead to system crash on TI dra7-evm board: >> >> WARNING: CPU: 0 PID: 3188 at drivers/bus/omap_l3_noc.c:148 l3_interrupt_handler+0x258/0x374() >> 44000000.ocp:L3 Custom Error: MASTER MPU TARGET L4_PER1_P3 (Idle): Data Access in User mode during Functional access >> >> Hence, add missed PM_RESTORE_PREPARE PM event in mmc_pm_notify(). >> >> Signed-off-by: Grygorii Strashko > > Huh, that was an old bug you found. :-) oh yes. it's happened thanks to HW issue on my board which generates a flood of SDCD IRQs :) It's the worst case ever to track wrong/missed PM notifiers ( > > I have applied it for fixes and added the below fixes tag. > > Fixes: 4c2ef25fe0b8 (mmc: fix all hangs related to mmc/sd card > insert/removal during suspend/resume) Thanks. -- regards, -grygorii