From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH] thermal: exynos: Disable the regulator on probe failure Date: Mon, 06 Jul 2015 16:02:20 +0900 Message-ID: <559A27FC.5070902@samsung.com> References: <1433727349-23330-1-git-send-email-k.kozlowski@samsung.com> <20150608181459.454c9067@amdc2363> <20150706090133.71b4be9b@amdc2363> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-reply-to: <20150706090133.71b4be9b@amdc2363> Sender: linux-samsung-soc-owner@vger.kernel.org To: Lukasz Majewski Cc: Zhang Rui , Eduardo Valentin , Kukjin Kim , linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org List-Id: linux-pm@vger.kernel.org On 06.07.2015 16:01, Lukasz Majewski wrote: > Hi Krzysztof, >=20 >> 2015-06-09 1:14 GMT+09:00 Lukasz Majewski : >>> Hi Krzysztof, >>> >>>> During probe the regulator (if present) was enabled but not >>>> disabled in case of failure. So an unsuccessful probe lead to >>>> enabling the regulator which was actually not needed because the >>>> device was not enabled. >>>> >>>> Additionally each deferred probe lead to increase of regulator >>>> enable count so it would not be effectively disabled during >>>> removal of the device. >>> >>> Thanks for catching this. >>> >>>> >>>> Signed-off-by: Krzysztof Kozlowski >>>> Fixes: 498d22f616f6 ("thermal: exynos: Support for TMU regulator >>>> defined at device tree") Cc: >>>> >>>> --- >>>> >>>> I am not entirely convinced that this should go to stable. Leaving >>>> a regulator enabled in case of probe failure (no exynos TMU >>>> device) or after deferred probe (regulator won't be disabled >>>> during device removal) is not a critical issue, just leaks power. >>>> --- >>>> drivers/thermal/samsung/exynos_tmu.c | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/drivers/thermal/samsung/exynos_tmu.c >>>> b/drivers/thermal/samsung/exynos_tmu.c index >>>> 531f4b179871..13c3aceed19d 100644 --- >>>> a/drivers/thermal/samsung/exynos_tmu.c +++ >>>> b/drivers/thermal/samsung/exynos_tmu.c @@ -1392,6 +1392,8 @@ >>>> err_clk_sec: if (!IS_ERR(data->clk_sec)) >>>> clk_unprepare(data->clk_sec); >>>> err_sensor: >>>> + if (!IS_ERR_OR_NULL(data->regulator)) >>>> + regulator_disable(data->regulator); >>>> thermal_zone_of_sensor_unregister(&pdev->dev, data->tzd); >>>> >>>> return ret; >>> >>> Acked-by: Lukasz Majewski >>> >>> I will test it and afterwards add to samsung-thermal tree. >> >> Hi =C5=81ukasz, >> >> I can't find this patch in v4.2-rc1 or your tree. What happened? >=20 > I will got together with Chanowoo patches. I will send PR today to > Eduardo. Thanks! Best regards, Krzysztof