From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanimir Varbanov Subject: Re: [PATCH v6 03/13] clk: qcom: gdsc: Use PM clocks to control gdsc clocks Date: Thu, 23 Jul 2015 12:22:29 +0300 Message-ID: <55B0B255.9050803@mm-sol.com> References: <1437549069-29655-1-git-send-email-rnayak@codeaurora.org> <1437549069-29655-4-git-send-email-rnayak@codeaurora.org> <55B03CE9.4050903@codeaurora.org> <55B0A710.9080209@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from ns.mm-sol.com ([37.157.136.199]:47149 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752217AbbGWJWq (ORCPT ); Thu, 23 Jul 2015 05:22:46 -0400 In-Reply-To: <55B0A710.9080209@codeaurora.org> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Rajendra Nayak , Stephen Boyd Cc: mturquette@baylibre.com, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, georgi.djakov@linaro.org, srinivas.kandagatla@linaro.org, sviau@codeaurora.org On 07/23/2015 11:34 AM, Rajendra Nayak wrote: > On 07/23/2015 06:31 AM, Stephen Boyd wrote: >> On 07/22/2015 12:10 AM, Rajendra Nayak wrote: >>> @@ -104,6 +105,37 @@ static int gdsc_disable(struct generic_pm_domain >>> *domain) >>> return gdsc_toggle_logic(sc, false); >>> } >>> +static int gdsc_attach(struct generic_pm_domain *domain, struct >>> device *dev) >>> +{ >>> + int ret; >>> + struct gdsc *sc = domain_to_gdsc(domain); >>> + char **con_id, *con_ids[] = { "core", "iface", NULL }; >> >> const? >> >> This is where I get scared of sniffing too much SoC glue. What's to >> enforce the "core", and "iface" naming scheme? What's to enforce there >> being two clocks vs. one? Maybe a better approach would be to use >> of_clk_get() and iterate through all clocks of the device, or to encode >> the clock names in the gdsc structure. > > I had the clock names in the gdsc structure in v5. I should probably go > back to having it that way. Rajendra, If you decide to go back please look at that comment [1], as well. -- regards, Stan [1] http://www.spinics.net/lists/linux-arm-msm/msg15040.html