From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Andrew F. Davis" Subject: Re: [PATCH 8/8] power: bq27xxx_battery: Cleanup health checking Date: Fri, 24 Jul 2015 15:32:01 -0500 Message-ID: <55B2A0C1.4000906@ti.com> References: <1437601920-13045-1-git-send-email-afd@ti.com> <1437601920-13045-9-git-send-email-afd@ti.com> <20150723162212.GI29125@pali> <1437671193.26573.10.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from devils.ext.ti.com ([198.47.26.153]:45545 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753504AbbGXUc1 (ORCPT ); Fri, 24 Jul 2015 16:32:27 -0400 In-Reply-To: <1437671193.26573.10.camel@perches.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Joe Perches , =?windows-1252?Q?Pali_Roh=E1r?= Cc: Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Dan Murphy , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org On 07/23/2015 12:06 PM, Joe Perches wrote: > On Thu, 2015-07-23 at 18:22 +0200, Pali Roh=E1r wrote: >> On Wednesday 22 July 2015 16:52:00 Andrew F. Davis wrote: >>> Reorganize the logic checking battery health and under temperature >>> condition checking. > [] >>> diff --git a/drivers/power/bq27xxx_battery.c b/drivers/power/bq27xx= x_battery.c > [] >>> @@ -624,10 +626,34 @@ static int bq27xxx_battery_read_pwr_avg(struc= t bq27xxx_device_info *di) >>> */ >>> static int bq27xxx_battery_overtemp(struct bq27xxx_device_info *di= , u16 flags) >>> { >>> - if (di->chip =3D=3D BQ27500 || di->chip =3D=3D BQ27541) >>> + if (di->chip =3D=3D BQ27500 || di->chip =3D=3D BQ27541 || di->chi= p =3D=3D BQ27545) >>> return flags & (BQ27XXX_FLAG_OTC | BQ27XXX_FLAG_OTD); >>> + if (di->chip =3D=3D BQ27530 || di->chip =3D=3D BQ27421) >>> + return flags & BQ27XXX_FLAG_OT; >>> + >>> + return false; >=20 > Maybe this int function should be bool or return 0 > instead of false. >=20 >>> +static int bq27xxx_battery_undertemp(struct bq27xxx_device_info *d= i, u16 flags) >>> +{ >>> + if (di->chip =3D=3D BQ27530 || di->chip =3D=3D BQ27421) >>> + return flags & BQ27XXX_FLAG_UT; >>> + >>> + return false; >>> +} >=20 > Here too >=20 >>> + >>> +/* >>> + * Returns true if a low state of charge condition is detected >>> + */ >>> +static int bq27xxx_battery_dead(struct bq27xxx_device_info *di, u1= 6 flags) >>> +{ >>> + if (di->chip =3D=3D BQ27000 || di->chip =3D=3D BQ27010) >>> + return flags & (BQ27000_FLAG_EDV1 | BQ27000_FLAG_EDVF); >>> else >>> - return flags & BQ27XXX_FLAG_OTC; >>> + return flags & (BQ27XXX_FLAG_SOC1 | BQ27XXX_FLAG_SOCF); >>> } >=20 > and here >=20 >=20 I think I'll change the return to bool as these functions are only used= in an if statement checking for true/false. Thanks, Andrew