From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v2] thermal: consistently use int for temperatures Date: Fri, 24 Jul 2015 15:49:41 -0700 Message-ID: <55B2C105.3040600@roeck-us.net> References: <1437463292-24844-1-git-send-email-s.hauer@pengutronix.de> <20150723120759.GA17690@amd> <20150724062948.GK18700@pengutronix.de> <55B244BE.1060203@roeck-us.net> <20150724221102.GA31517@amd> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20150724221102.GA31517@amd> Sender: linux-acpi-owner@vger.kernel.org To: Pavel Machek Cc: Sascha Hauer , linux-pm@vger.kernel.org, Zhang Rui , Eduardo Valentin , linux-kernel@vger.kernel.org, Punit Agrawal , Jean Delvare , Peter Feuerer , Heiko Stuebner , Lukasz Majewski , Stephen Warren , Thierry Reding , linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, "Rafael J. Wysocki" , Maxime Ripard , Darren Hart , lm-sensors@lm-sensors.org List-Id: linux-pm@vger.kernel.org On 07/24/2015 03:11 PM, Pavel Machek wrote: > On Fri 2015-07-24 06:59:26, Guenter Roeck wrote: >> On 07/23/2015 11:29 PM, Sascha Hauer wrote: >>> On Thu, Jul 23, 2015 at 02:07:59PM +0200, Pavel Machek wrote: >>>> On Tue 2015-07-21 09:21:32, Sascha Hauer wrote: >>>>> The thermal code uses int, long and unsigned long for temperature= s >>>>> in different places. >>>>> >>>>> Using an unsigned type limits the thermal framework to positive >>>>> temperatures without need. Also several drivers currently will re= port >>>>> temperatures near UINT_MAX for temperatures below 0=B0C. This wil= l probably >>>>> immediately shut the machine down due to overtemperature if start= ed below >>>>> 0=B0C. >>>>> >>>>> 'long' is 64bit on several architectures. This is not needed sinc= e INT_MAX =B0mC >>>>> is above the melting point of all known materials. >>>> >>>> Can we do something like >>>> >>>> typedef millicelsius_t int; >>>> >>>> ...to document the units? >>> >>> I am not very fond of typedefs and I am not sure this adds any valu= e. I >>> could change it when more people ask for it, but I just sent the ne= w >>> version without this. >>> >> >> I thought we are supposed to not introduce new typedefs anyway. > > You are not supposed to typedef struct, but typedef for millicelsius_= t > would be ok. And it is your only chance if you want people to pay > attention. If you make it int, someone will pass it to long or > something else.. Seems to me that would be just lazyness. The same person might use 'lon= g' even if millicelsius_t is defined. A typedef doesn't preclude people from ignoring it. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html