From: "Andrew F. Davis" <afd@ti.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
"Sebastian Reichel" <sre@kernel.org>,
"Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
"David Woodhouse" <dwmw2@infradead.org>,
"Dan Murphy" <dmurphy@ti.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/6] power: bq27xxx_battery: Add support for additional bq27xxx family devices
Date: Sun, 2 Aug 2015 12:43:17 -0500 [thread overview]
Message-ID: <55BE56B5.6040608@ti.com> (raw)
In-Reply-To: <20150802073853.GD3720@amd>
On 08/02/2015 02:38 AM, Pavel Machek wrote:
>
>> +#define INVALID_REG_ADDR 0xff
>
>> +static u8 bq27000_regs[] = {
>> + 0x00, /* CONTROL */
>> + 0x06, /* TEMP */
>> + 0xff, /* INT TEMP - NA*/
>
> I'd use the INVALID_REG_ADDR macro here.. Makes it more clear what is
> going on (and you may change it to -1 in future, for example).
>
That works, I'll do that.
Thanks,
--
Andrew F. Davis
next prev parent reply other threads:[~2015-08-02 17:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 19:39 [PATCH v2 0/6] Add support for additional bq27xxx devices Andrew F. Davis
2015-07-28 19:39 ` [PATCH v2 1/6] power: bq27x00_battery: Remove unneeded i2c MODULE_ALIAS Andrew F. Davis
2015-07-28 20:00 ` Pali Rohár
2015-07-28 19:39 ` [PATCH v2 2/6] power: bq27x00_battery: Renaming for consistency Andrew F. Davis
2015-07-28 20:04 ` Pali Rohár
2015-08-02 7:31 ` Pavel Machek
2015-08-02 17:41 ` Andrew F. Davis
2015-07-28 19:39 ` [PATCH v2 3/6] power: bq27xxx_battery: Platform initialization must declare a device Andrew F. Davis
2015-07-28 20:13 ` Pali Rohár
2015-07-30 17:01 ` Andrew F. Davis
2015-07-28 19:39 ` [PATCH v2 4/6] power: bq27xxx_battery: Fix typos and change naming for state of charge functions Andrew F. Davis
2015-07-28 20:14 ` Pali Rohár
2015-08-02 7:37 ` Pavel Machek
2015-07-28 19:39 ` [PATCH v2 5/6] power: bq27xxx_battery: Add support for additional bq27xxx family devices Andrew F. Davis
2015-07-28 19:59 ` Pali Rohár
2015-07-30 17:07 ` Andrew F. Davis
2015-08-02 7:38 ` Pavel Machek
2015-08-02 17:43 ` Andrew F. Davis [this message]
2015-07-28 19:39 ` [PATCH v2 6/6] power: bq27xxx_battery: Cleanup health checking Andrew F. Davis
2015-07-28 20:16 ` Pali Rohár
2015-08-02 7:36 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BE56B5.6040608@ti.com \
--to=afd@ti.com \
--cc=dbaryshkov@gmail.com \
--cc=dmurphy@ti.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).