From: Chanwoo Choi <cw00.choi@samsung.com>
To: myungjoo.ham@samsung.com
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH] PM / devfreq: exynos-ppmu: bit-wise operation bugfix.
Date: Wed, 05 Aug 2015 11:19:08 +0900 [thread overview]
Message-ID: <55C1729C.3090408@samsung.com> (raw)
In-Reply-To: <1139776636.447211438740931685.JavaMail.weblogic@epmlwas03c>
On 08/05/2015 11:15 AM, MyungJoo Ham wrote:
>
> Make it u64 before left-shifting 32bits.
>
> Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
> ---
> drivers/devfreq/event/exynos-ppmu.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
> index f9901f5..f312485 100644
> --- a/drivers/devfreq/event/exynos-ppmu.c
> +++ b/drivers/devfreq/event/exynos-ppmu.c
> @@ -319,7 +319,8 @@ static int exynos_ppmu_v2_get_event(struct devfreq_event_dev *edev,
> case PPMU_PMNCNT3:
> pmcnt_high = __raw_readl(info->ppmu.base + PPMU_V2_PMCNT3_HIGH);
> pmcnt_low = __raw_readl(info->ppmu.base + PPMU_V2_PMCNT3_LOW);
> - load_count = (u64)((pmcnt_high & 0xff) << 32) + (u64)pmcnt_low;
> + load_count = ((u64)((pmcnt_high & 0xff)) << 32)
> + + (u64)pmcnt_low;
> break;
> }
> edata->load_count = load_count;
>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Thanks,
Chanwoo Choi
prev parent reply other threads:[~2015-08-05 2:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 2:15 [PATCH] PM / devfreq: exynos-ppmu: bit-wise operation bugfix MyungJoo Ham
2015-08-05 2:19 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C1729C.3090408@samsung.com \
--to=cw00.choi@samsung.com \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).