linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shreyas B Prabhu <shreyas@linux.vnet.ibm.com>
To: Thomas Renninger <trenn@suse.de>
Cc: rjw@rjwysocki.net, pavsubra@linux.vnet.ibm.com,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] cpupower tools: Fix error when running cpupower monitor
Date: Mon, 17 Aug 2015 13:22:15 +0530	[thread overview]
Message-ID: <55D192AF.5000602@linux.vnet.ibm.com> (raw)
In-Reply-To: <9534146.fFc3TD2C5D@skinner>



On 08/10/2015 05:58 PM, Thomas Renninger wrote:
> On Monday, August 03, 2015 11:46:00 AM Shreyas B. Prabhu wrote:
>> get_cpu_topology() tries to get topology info from all cpus by reading
>> files in the topology sysfs dir. If a cpu is offlined, since it doesn't
>> have topology dir, this function fails and returns -1. This causes
>> functions relying on get_cpu_topology() to fail. For example-
>>
>> $ cpupower monitor
>> Cannot read number of available processors
>>
>> Fix this by skipping fetching topology info for offline cpus.
> 
> Looks fine.
> 
> Thanks!
> 
> Acked-by: Thomas Renninger <trenn@suse.de>
> 

Thanks Thomas!
Rafael, can you please pick this patch?


Thanks,
Shreyas

  reply	other threads:[~2015-08-17  7:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-03  6:16 [PATCH] cpupower tools: Fix error when running cpupower monitor Shreyas B. Prabhu
2015-08-10 12:28 ` Thomas Renninger
2015-08-17  7:52   ` Shreyas B Prabhu [this message]
2015-08-25 11:59     ` Shreyas B Prabhu
2015-09-03  6:21       ` Shreyas B Prabhu
2015-09-04 14:51         ` Rafael J. Wysocki
2015-09-04 14:29           ` Shreyas B Prabhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55D192AF.5000602@linux.vnet.ibm.com \
    --to=shreyas@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavsubra@linux.vnet.ibm.com \
    --cc=rjw@rjwysocki.net \
    --cc=trenn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).