From: Yu Chen <yu.c.chen@intel.com>
To: Pavel Machek <pavel@ucw.cz>, Ingo Molnar <mingo@kernel.org>
Cc: rjw@rjwysocki.net, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, rui.zhang@intel.com, x86@kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86, suspend: Save/restore THERM_CONTROL register for suspend
Date: Tue, 18 Aug 2015 10:23:40 +0800 [thread overview]
Message-ID: <55D2972C.3030709@intel.com> (raw)
In-Reply-To: <20150817132726.GA11047@amd>
Hi Pavel, thanks for your review,
On 08/17/2015 09:27 PM, Pavel Machek wrote:
> On Mon 2015-08-17 12:11:15, Ingo Molnar wrote:
>>
>> * Chen Yu <yu.c.chen@intel.com> wrote:
>>
>>> A bug is reported(https://bugzilla.redhat.com/show_bug.cgi?id=1227208)
>
> Access denied :-(
>
Might need to register for accessing.
>
> What HW is this on?
>
Intel Braswell and Broadwell, detail for Broadwell:
Platform: MayanCity
Processor: 2x BROADWELL BDX_EP A0 QHPR
Chipset: Wellsburg B1 QR7E
>
> - So BIOS expects to control MSR_IA32_THERM_CONTROL . Now you suspend
> in hot enironment but resume in cool one. BIOS sets up
> MSR_IA32_THERM_CONTROL the right way, but you override it.
>
> As BIOS expects to control MSR_IA32_THERM_CONTROL and machine is
> kept cool, BIOS will not write new value to it, and machine will
> keep running slowly.
>
Sorry, I can not quite catch up, do you mean we should let
BIOS modifying MSR_IA32_THERM_CONTROL and leverage linux
to adjust this value at runtime(after S3)?
> Doing this unconditionally is asking for trouble. Blacklist entry with
> affected BIOS info might be acceptable, but...
> Pavel
>
you mean a quirk here(accroding to dmi info ,etc)?
Best Regards,
Yu
next prev parent reply other threads:[~2015-08-18 2:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-17 8:29 [PATCH] x86, suspend: Save/restore THERM_CONTROL register for suspend Chen Yu
2015-08-17 10:11 ` Ingo Molnar
2015-08-17 11:43 ` Chen, Yu C
2015-08-17 13:27 ` Pavel Machek
2015-08-18 2:23 ` Yu Chen [this message]
2015-08-18 8:02 ` Pavel Machek
2015-08-18 8:54 ` Yu Chen
2015-08-18 2:02 ` Yu Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D2972C.3030709@intel.com \
--to=yu.c.chen@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).