From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Nowicki Subject: Re: [PATCH] x86, arm64, acpi: Handle lapic/x2apic entries in MADT Date: Tue, 01 Sep 2015 15:36:46 +0200 Message-ID: <55E5A9EE.3030704@linaro.org> References: <55DDB45D.2030901@arm.com> <1440611369-26314-1-git-send-email-lukasz.anaczkowski@intel.com> <1440611369-26314-2-git-send-email-lukasz.anaczkowski@intel.com> <55E55BA8.5090102@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-la0-f46.google.com ([209.85.215.46]:35575 "EHLO mail-la0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752633AbbIANgx (ORCPT ); Tue, 1 Sep 2015 09:36:53 -0400 Received: by lanb10 with SMTP id b10so57618621lan.2 for ; Tue, 01 Sep 2015 06:36:51 -0700 (PDT) In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: "Anaczkowski, Lukasz" , "marc.zyngier@arm.com" , "lorenzo.pieralisi@arm.com" , "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "x86@kernel.org" , "jason@lakedaemon.net" Cc: "rjw@rjwysocki.net" , "Brown, Len" , "pavel@ucw.cz" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , Yinghai Lu On 01.09.2015 14:07, Anaczkowski, Lukasz wrote: > From: Tomasz Nowicki [mailto:tomasz.nowicki@linaro.org] > Sent: Tuesday, September 1, 2015 10:03 AM > >>> To fix this, each LAPIC/X2APIC entry from MADT table needs to be >>> handled at the same time when processing it, thus adding >>> acpi_subtable_proc structure which stores >>> () ACPI table id >>> () handler that processes table >>> () counter how many items has been processed and passing it to >>> acpi_table_parse_entries(). > >> Why can't you leave the parsing code as is and create ApicId sorted list while parsing LAPIC/X2APIC? You could call acpi_register_lapic() after all... Do I miss something ? > > Just to make sure I understand correctly - you suggest to replace calls to acpi_register_lapic() with a code that builds an APIC ID list while parsing LAPIC/X2APIC, and after parsing is done, > go thru the list and call acpi_register_lapic() on each APIC ID, correct? > Yes, does it work for you? Tomasz