From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Andrew F. Davis" <afd@ti.com>
Subject: Re: [patch] power: bq27xxx_battery: signedness bug in
 bq27xxx_battery_read_health()
Date: Mon, 28 Sep 2015 10:08:37 -0500
Message-ID: <560957F5.3090900@ti.com>
References: <20150928091653.GA11367@mwanda>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-pm-owner@vger.kernel.org>
Received: from comal.ext.ti.com ([198.47.26.152]:55243 "EHLO comal.ext.ti.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S933851AbbI1PJV (ORCPT <rfc822;linux-pm@vger.kernel.org>);
	Mon, 28 Sep 2015 11:09:21 -0400
In-Reply-To: <20150928091653.GA11367@mwanda>
Sender: linux-pm-owner@vger.kernel.org
List-Id: linux-pm@vger.kernel.org
To: Dan Carpenter <dan.carpenter@oracle.com>, =?UTF-8?Q?Pali_Roh=c3=a1r?= <pali.rohar@gmail.com>
Cc: Sebastian Reichel <sre@kernel.org>, Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>, David Woodhouse <dwmw2@infradead.org>, linux-pm@vger.kernel.org, kernel-janitors@vger.kernel.org

On 09/28/2015 04:16 AM, Dan Carpenter wrote:
> We need flags to be signed for the error handling to work.
>
> Fixes: 74aab849f342 ('power: bq27xxx_battery: Cleanup health checking')

This bug looks to have been added back in c91d36ea8116, either way the
fix itself is correct so,

> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>

Acked-by: Andrew F. Davis <afd@ti.com>

> diff --git a/drivers/power/bq27xxx_battery.c b/drivers/power/bq27xxx_battery.c
> index 473aa2f..994c78d 100644
> --- a/drivers/power/bq27xxx_battery.c
> +++ b/drivers/power/bq27xxx_battery.c
> @@ -691,7 +691,7 @@ static bool bq27xxx_battery_dead(struct bq27xxx_device_info *di, u16 flags)
>    */
>   static int bq27xxx_battery_read_health(struct bq27xxx_device_info *di)
>   {
> -	u16 flags;
> +	int flags;
>
>   	flags = bq27xxx_read(di, BQ27XXX_REG_FLAGS, false);
>   	if (flags < 0) {
>