From: Prarit Bhargava <prarit@redhat.com>
To: Thomas Renninger <trenn@suse.de>
Cc: Jacob Tanenbaum <jtanenba@redhat.com>, linux-pm@vger.kernel.org
Subject: Re: cpupower reports uninitialized values for offline cpus
Date: Thu, 01 Oct 2015 09:11:55 -0400 [thread overview]
Message-ID: <560D311B.8090507@redhat.com> (raw)
In-Reply-To: <3211183.5fvOAutzxZ@skinner>
On 10/01/2015 08:29 AM, Thomas Renninger wrote:
> On Wednesday, September 30, 2015 02:25:47 PM Prarit Bhargava wrote:
>> On 09/30/2015 12:23 PM, Thomas Renninger wrote:
> ...
>> Yeah, we'd have to add an additional state to the CPU hotplug callback state
>> machine (CPU_ADD_PHYSICAL?) to identify when a cpu was hot-added. I
>> suppose it could be done but it seems like an awful lot of churn for little
>> gain.
>
> It shouldn't be that hard.
> If I find some time I give it a try.
> This is a rather central piece of kernel code and affects
> more or less all architectures, so getting this finally mainline
> may take a while...
>
> So it would be nice if somewhen in the future we have 2 independent
> fixes:
>
> The cpupower one as you wrote before, ignoring cores without
> topology sysfs info (but not simply checking for "is core offline"),
> better check whether the directory or a specific file exists.
>
> And a kernel one which still shows topology info of soft offlined
> cores which with above cpupower solution will result in previous
> output (offlined cores listed, but with valid topology info).
>
> Makes sense?
Yup, makes sense. Jacob (Jake) is going to handle the cpupower stuff right
away. I'll dive into the topology stuff in a little bit and/or assist Jake with it.
Thanks Thomas :)
P.
>
> Thomas
>
prev parent reply other threads:[~2015-10-01 13:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 18:58 cpupower reports uninitialized values for offline cpus Jacob Tanenbaum
2015-09-29 20:25 ` Prarit Bhargava
2015-09-30 16:23 ` Thomas Renninger
2015-09-30 18:25 ` Prarit Bhargava
2015-10-01 12:29 ` Thomas Renninger
2015-10-01 13:11 ` Prarit Bhargava [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560D311B.8090507@redhat.com \
--to=prarit@redhat.com \
--cc=jtanenba@redhat.com \
--cc=linux-pm@vger.kernel.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).