From: Prarit Bhargava <prarit@redhat.com>
To: Doug Smythies <dsmythies@telus.net>
Cc: 'Kristen Carlson Accardi' <kristen@linux.intel.com>,
linux-kernel@vger.kernel.org,
'Viresh Kumar' <viresh.kumar@linaro.org>,
linux-pm@vger.kernel.org,
"'Rafael J. Wysocki'" <rjw@rjwysocki.net>
Subject: Re: [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch
Date: Wed, 07 Oct 2015 16:40:44 -0400 [thread overview]
Message-ID: <5615834C.80108@redhat.com> (raw)
In-Reply-To: <000f01d10131$59c67a60$0d536f20$@net>
On 10/07/2015 02:52 PM, Doug Smythies wrote:
> On 2015.10.07 08:46 Prarit Bhargava wrote:
>> On 10/07/2015 11:40 AM, Doug Smythies wrote:
>>>
>>> Do we agree or disagree that the root issue seems to be (from your test)?:
>>>
>>> \# echo 100 > /sys/devices/system/cpu/intel_pstate/min_perf_pct
>>>
>>> [ 21.483436] store_min_perf_pct[453] min_sysfs_pct = 100
>>> [ 21.489373] store_min_perf_pct[456] min_perf_pct = 100
>>> [ 21.495203] store_min_perf_pct[459] min_perf_pct = 100
>>> [ 21.501050] store_min_perf_pct[462] min_perf_pct = 100
>>
>> Yep, and it appears to be done by default in Fedora & RHEL :/ ... the issue is
>> still the same IMO that min_sysfs_pct & max_sysfs_pct are not cleared on a
>> governor switch.
>
> Clearing them will break some other things. For example, and as
> shown in my original reply, resume from suspend.
>
> Why? Because, at least on my computer, the governor is changed to
> "performance" during suspend, and the "powersave" governor is
> restored sometime during resume. The users wants the settings they had
> before the suspend.
Hmm ... okay. I'm going to try again with a new patch and I'll add an
additional test of starting with the powersave governor, changing the
min_perf_pct, and then doing a suspend/resume.
P.
next prev parent reply other threads:[~2015-10-07 20:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 21:49 [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch Prarit Bhargava
2015-10-06 22:43 ` Rafael J. Wysocki
2015-10-06 23:06 ` Rafael J. Wysocki
2015-10-07 6:51 ` Doug Smythies
2015-10-07 9:59 ` Prarit Bhargava
2015-10-07 14:04 ` Doug Smythies
2015-10-07 14:10 ` Prarit Bhargava
2015-10-07 15:40 ` Doug Smythies
2015-10-07 15:46 ` Prarit Bhargava
2015-10-07 18:52 ` Doug Smythies
2015-10-07 20:40 ` Prarit Bhargava [this message]
2015-10-07 21:31 ` Prarit Bhargava
2015-10-07 22:05 ` Rafael J. Wysocki
2015-10-07 22:26 ` Doug Smythies
2015-10-07 23:17 ` Prarit Bhargava
2015-10-08 0:13 ` Prarit Bhargava
2015-10-07 23:08 ` Prarit Bhargava
2015-10-07 14:34 ` Prarit Bhargava
2015-10-07 11:38 ` Prarit Bhargava
2015-10-07 12:18 ` Prarit Bhargava
2015-10-07 14:50 ` Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5615834C.80108@redhat.com \
--to=prarit@redhat.com \
--cc=dsmythies@telus.net \
--cc=kristen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).