From: Saravana Kannan <skannan@codeaurora.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH Resend] cpufreq: Drop redundant check for inactive policies
Date: Wed, 14 Oct 2015 18:51:07 -0700 [thread overview]
Message-ID: <561F068B.60506@codeaurora.org> (raw)
In-Reply-To: <90321921.5bFa9a5dDU@vostro.rjw.lan>
On 10/14/2015 05:35 PM, Rafael J. Wysocki wrote:
> On Tuesday, October 13, 2015 10:57:13 AM Viresh Kumar wrote:
>> We just made sure policy->cpu is online and this check will always fail
>> as the policy is active. Drop it.
>>
>> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
>> Acked-by: Saravana Kannan <skannan@codeaurora.org>
>
> Applied, thanks!
>
> Rafael
>
I didn't give a clear ack/review for the series. So, to clarify my
ack/review
For all patches except 4/5, I'm okay with either/all of this:
Reviewed-by: Saravana Kannan <skannan@codeaurora.org>
Acked-by: Saravana Kannan <skannan@codeaurora.org>
For 4/5, I would still like us to move the sysfs creating after init.
That part shouldn't be too hard. We don't need to create the sysfs file
before init.
Once that's done, I wouldn't mind giving an Ack.
Thanks,
Saravana
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2015-10-15 1:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 5:27 [PATCH Resend] cpufreq: Drop redundant check for inactive policies Viresh Kumar
2015-10-15 0:35 ` Rafael J. Wysocki
2015-10-15 1:51 ` Saravana Kannan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561F068B.60506@codeaurora.org \
--to=skannan@codeaurora.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).