From: "Andrew F. Davis" <afd@ti.com>
To: "Pali Rohár" <pali.rohar@gmail.com>,
"Sebastian Reichel" <sre@kernel.org>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] power: bq27xxx_battery: fix defined but not used warnings
Date: Fri, 16 Oct 2015 10:01:33 -0500 [thread overview]
Message-ID: <5621114D.7010002@ti.com> (raw)
In-Reply-To: <20151016144705.GG28216@pali>
On 10/16/2015 09:47 AM, Pali Rohár wrote:
> On Friday 16 October 2015 15:44:12 Sebastian Reichel wrote:
>> If BQ27XXX is enabled, but neither I2C based initialization, nor
>> platform based initialization are activated, bq27xxx_powersupply_init
>> and bq27xxx_powersupply_unregister are defined but not used.
>>
>> This configuration doesn't make sense, but there is no easy way
>> to make it unavailable in the build system, so just mark the
>> functions as __maybe_unused instead.
>>
>
> What about?
>
> #if defined(CONFIG_1) || defined(CONFIG_2)
> #define NEED_POWER_SUPPLY
> #endif
>
> And then wrap power supply code into #ifdef NEED_POWER_SUPPLY?
>
We would need to wrap everything in that then, so without I2C or
platform enabled we end up compiling an empty file. I think the
better fix would be to modify the Kconfig, something like:
config BATTERY_BQ27XXX
tristate
depends on (BATTERY_BQ27XXX_I2C || BATTERY_BQ27XXX_PLATFORM)
default y
config BATTERY_BQ27XXX_I2C
bool "BQ27200/BQ27500 support"
depends on I2C
help
Say Y here to enable support for batteries with BQ27x00 (I2C) chips.
config BATTERY_BQ27XXX_PLATFORM
bool "BQ27000 support"
help
Say Y here to enable support for batteries with BQ27000 (HDQ) chips.
This would be more in line with how other multi-bus devices handle
this issue when nether bus is selected.
--
Andrew F. Davis
next prev parent reply other threads:[~2015-10-16 15:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 13:44 [PATCH 0/3] power: bq27xxx: Fix multiple defined but not used warnings Sebastian Reichel
2015-10-16 13:44 ` [PATCH 1/3] power: bq27xxx_battery: fix platform probe Sebastian Reichel
2015-10-16 14:47 ` Pali Rohár
2015-10-16 14:53 ` Andrew F. Davis
2015-10-16 13:44 ` [PATCH 2/3] power: bq27xxx_battery: move irq handler to i2c section Sebastian Reichel
2015-10-16 14:48 ` Pali Rohár
2015-10-16 15:06 ` Andrew F. Davis
2015-10-16 13:44 ` [PATCH 3/3] power: bq27xxx_battery: fix defined but not used warnings Sebastian Reichel
2015-10-16 14:47 ` Pali Rohár
2015-10-16 15:01 ` Andrew F. Davis [this message]
2015-10-19 9:37 ` Sebastian Reichel
2015-10-19 16:33 ` Andrew F. Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5621114D.7010002@ti.com \
--to=afd@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).