From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: Re: [PATCH] thermal: exynos: Fix register read in TMU Date: Sat, 17 Oct 2015 08:20:27 +0900 Message-ID: <5621863B.6000603@kernel.org> References: <1444693909-17754-1-git-send-email-k.kozlowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1444693909-17754-1-git-send-email-k.kozlowski@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Krzysztof Kozlowski Cc: Kukjin Kim , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lukasz Majewski , Zhang Rui , Eduardo Valentin , linux-pm@vger.kernel.org, Sudip Mukherjee , Sudip Mukherjee List-Id: linux-pm@vger.kernel.org On 10/13/15 08:51, Krzysztof Kozlowski wrote: > From: Sudip Mukherjee > > The value of emul_con was getting overwritten if the selected soc is > SOC_ARCH_EXYNOS5260. And so as a result we were reading from the wrong > register in the case of SOC_ARCH_EXYNOS5260. > > Signed-off-by: Sudip Mukherjee > Reviewed-by: Krzysztof Kozlowski > Reviewed-by: Chanwoo Choi > Acked-by: Lukasz Majewski > Fixes: 488c7455d74c ("thermal: exynos: Add the support for Exynos5433 TMU") > Signed-off-by: Krzysztof Kozlowski > --- > drivers/thermal/samsung/exynos_tmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c > index 0bae8cc6c23a..ca920b0ecf8f 100644 > --- a/drivers/thermal/samsung/exynos_tmu.c > +++ b/drivers/thermal/samsung/exynos_tmu.c > @@ -932,7 +932,7 @@ static void exynos4412_tmu_set_emulation(struct exynos_tmu_data *data, > > if (data->soc == SOC_ARCH_EXYNOS5260) > emul_con = EXYNOS5260_EMUL_CON; > - if (data->soc == SOC_ARCH_EXYNOS5433) > + else if (data->soc == SOC_ARCH_EXYNOS5433) > emul_con = EXYNOS5433_TMU_EMUL_CON; > else if (data->soc == SOC_ARCH_EXYNOS7) > emul_con = EXYNOS7_TMU_REG_EMUL_CON; Applied, thanks. - Kukjin