Linux Power Management development
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Saurabh Sengar <saurabh.truth@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH v2] PM / suspend: replacing printk
Date: Tue, 27 Oct 2015 20:36:13 +0100	[thread overview]
Message-ID: <562FD22D.2030206@nod.at> (raw)
In-Reply-To: <CAA8avJ9-VNKt=otfhjPtDQq1Tq38=P=Bx=3v7dH58ymKT5Mr6w@mail.gmail.com>

Am 27.10.2015 um 20:32 schrieb Saurabh Sengar:
> it fixes the checkpatch.pl <http://checkpatch.pl> warnings

Don't get me wrong, but checkpatch.pl is only a script which makes suggestions.
Especially as these are only warnings and not errors.

IMHO the code is perfectly fine as is.

Thanks,
//richard

> On Oct 28, 2015 12:56 AM, "Richard Weinberger" <richard.weinberger@gmail.com <mailto:richard.weinberger@gmail.com>> wrote:
>>
>> On Tue, Oct 27, 2015 at 8:21 PM, Saurabh Sengar <saurabh.truth@gmail.com <mailto:saurabh.truth@gmail.com>> wrote:
>> > replacing prink(s) with appropriate pr_info and pr_err
>> >
>> > Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com <mailto:saurabh.truth@gmail.com>>
>> > ---
>> >  kernel/power/suspend.c | 6 +++---
>> >  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> In which way does this patch improve the existing code?
>> You describe what it does but not which problem it solves and
>> why this patch is necessary.
>>
>> --
>> Thanks,
>> //richard
> 

  parent reply	other threads:[~2015-10-27 19:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-27 19:21 [PATCH v2] PM / suspend: replacing printk Saurabh Sengar
2015-10-27 19:26 ` Richard Weinberger
     [not found]   ` <CAA8avJ9-VNKt=otfhjPtDQq1Tq38=P=Bx=3v7dH58ymKT5Mr6w@mail.gmail.com>
2015-10-27 19:36     ` Richard Weinberger [this message]
2015-10-27 19:37 ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=562FD22D.2030206@nod.at \
    --to=richard@nod.at \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rjw@rjwysocki.net \
    --cc=saurabh.truth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox