From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Viresh Kumar <viresh.kumar@linaro.org>, linux-pm@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Julia Lawall <julia.lawall@lip6.fr>
Subject: [PATCH] CPPC-CPUFreq: Delete an unnecessary check before the function call "kfree"
Date: Thu, 5 Nov 2015 21:15:27 +0100 [thread overview]
Message-ID: <563BB8DF.7020908@users.sourceforge.net> (raw)
In-Reply-To: <5317A59D.4@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 5 Nov 2015 21:10:29 +0100
The kfree() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/cpufreq/cppc_cpufreq.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
index 93c219f..e8cb334 100644
--- a/drivers/cpufreq/cppc_cpufreq.c
+++ b/drivers/cpufreq/cppc_cpufreq.c
@@ -166,8 +166,7 @@ static int __init cppc_cpufreq_init(void)
out:
for_each_possible_cpu(i)
- if (all_cpu_data[i])
- kfree(all_cpu_data[i]);
+ kfree(all_cpu_data[i]);
kfree(all_cpu_data);
return -ENODEV;
--
2.6.2
next prev parent reply other threads:[~2015-11-05 20:15 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5307CAA2.8060406@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402212321410.2043@localhost6.localdomain6>
[not found] ` <530A086E.8010901@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402231635510.1985@localhost6.localdomain6>
[not found] ` <530A72AA.3000601@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402240658210.2090@localhost6.localdomain6>
[not found] ` <530B5FB6.6010207@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402241710370.2074@hadrien>
[not found] ` <530C5E18.1020800@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402251014170.2080@hadrien>
[not found] ` <530CD2C4.4050903@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402251840450.7035@hadrien>
[not found] ` <530CF8FF.8080600@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402252117150.2047@localhost6.localdomain6>
[not found] ` <530DD06F.4090703@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402262129250.2221@localhost6.localdomain6>
[not found] ` <5317A59D.4@users.so urceforge.net>
[not found] ` <5317A59D.4@users.sourceforge.net>
2014-11-16 13:28 ` [PATCH 1/1] kernel-power: Deletion of an unnecessary check before the function call "vfree" SF Markus Elfring
2014-11-18 23:32 ` Rafael J. Wysocki
2014-11-19 11:26 ` [PATCH 1/1] PM-wakeup: Deletion of an unnecessary check before the function call "wakeup_source_unregister" SF Markus Elfring
2014-11-19 12:09 ` Dan Carpenter
2014-11-19 12:54 ` walter harms
2014-11-19 13:05 ` Dan Carpenter
2014-11-19 13:39 ` walter harms
2015-06-28 10:21 ` [PATCH] PM-wakeup: Delete unnecessary checks before two function calls SF Markus Elfring
2015-08-14 6:56 ` Pavel Machek
2016-07-22 20:35 ` SF Markus Elfring
2016-07-22 21:52 ` Rafael J. Wysocki
2016-07-23 5:32 ` SF Markus Elfring
2016-07-23 12:18 ` Rafael J. Wysocki
2016-07-23 15:14 ` [PATCH] PM-wakeup: Delete unnecessary checks before three " SF Markus Elfring
2016-07-28 19:33 ` Pavel Machek
2014-11-21 10:12 ` [PATCH 1/1] thermal: Exynos: Deletion of unnecessary checks before two " SF Markus Elfring
2014-11-21 10:17 ` Julia Lawall
2014-11-21 13:25 ` SF Markus Elfring
2014-11-21 16:17 ` [PATCH v2] " SF Markus Elfring
2014-12-01 4:50 ` [PATCH 1/1] thermal: int3403: Delete a check before thermal_zone_device_unregister() SF Markus Elfring
2014-12-08 4:15 ` Zhang Rui
2015-02-03 10:21 ` [PATCH] ti-soc-thermal: Delete an unnecessary check before the function call "cpufreq_cooling_unregister" SF Markus Elfring
2015-02-03 18:25 ` [PATCH] cpufreq-dt: " SF Markus Elfring
2015-02-04 14:42 ` Rafael J. Wysocki
2015-11-05 20:15 ` SF Markus Elfring [this message]
2015-11-06 1:42 ` [PATCH] CPPC-CPUFreq: Delete an unnecessary check before the function call "kfree" Viresh Kumar
2015-11-07 1:10 ` Rafael J. Wysocki
2015-11-06 15:56 ` [PATCH] bq2415x_charger: Delete unnecessary checks before the function call "of_node_put" SF Markus Elfring
2015-11-06 16:13 ` Pali Rohár
2016-07-23 13:02 ` [PATCH] power: generic-adc-battery: Delete unnecessary checks before the function call "iio_channel_release" SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563BB8DF.7020908@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).