From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v6 8/9] ARM: EXYNOS: rearrange static and non-static functions of PMU driver Date: Fri, 20 Nov 2015 14:10:44 +0900 Message-ID: <564EAB54.6020904@samsung.com> References: <1447740351-14246-1-git-send-email-pankaj.dubey@samsung.com> <1447740351-14246-9-git-send-email-pankaj.dubey@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout3.w1.samsung.com ([210.118.77.13]:29859 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751038AbbKTFKt (ORCPT ); Fri, 20 Nov 2015 00:10:49 -0500 In-reply-to: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Manish Badarkhe , Pankaj Dubey Cc: "linux-samsung-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-pm@vger.kernel.org, "kgene.kim@samsung.com" , thomas.ab@samsung.com, amitdanielk@gmail.com, olof@lixom.net, khilman@linaro.org, arnd@arndb.de On 20.11.2015 13:46, Manish Badarkhe wrote: > On Tue, Nov 17, 2015 at 11:35 AM, Pankaj Dubey wrote: >> This patch moves exynos_sys_powerdown_conf function above all >> static functions, to avoid confusion causing due to mixing of >> static-nonstatic-static functions and to improve readability of this >> driver. >> >> Signed-off-by: Pankaj Dubey >> Suggested-by: Krzysztof Kozlowski >> Reviewed-by: Krzysztof Kozlowski >> --- >> arch/arm/mach-exynos/pmu.c | 34 +++++++++++++++++----------------- >> 1 file changed, 17 insertions(+), 17 deletions(-) >> >> diff --git a/arch/arm/mach-exynos/pmu.c b/arch/arm/mach-exynos/pmu.c >> index 01cb649..a7741d4 100644 >> --- a/arch/arm/mach-exynos/pmu.c >> +++ b/arch/arm/mach-exynos/pmu.c >> @@ -39,23 +39,6 @@ u32 pmu_raw_readl(u32 offset) >> return readl_relaxed(pmu_base_addr + offset); >> } >> >> -static void exynos_power_off(void) >> -{ >> - unsigned int tmp; >> - >> - pr_info("Power down.\n"); >> - tmp = pmu_raw_readl(EXYNOS_PS_HOLD_CONTROL); >> - tmp ^= (1 << 8); >> - pmu_raw_writel(tmp, EXYNOS_PS_HOLD_CONTROL); >> - >> - /* Wait a little so we don't give a false warning below */ >> - mdelay(100); >> - >> - pr_err("Power down failed, please power off system manually.\n"); >> - while (1) >> - ; >> -} >> - >> void exynos_sys_powerdown_conf(enum sys_powerdown mode) >> { >> unsigned int i; >> @@ -85,6 +68,23 @@ void exynos_sys_powerdown_conf(enum sys_powerdown mode) >> } >> } >> >> +static void exynos_power_off(void) >> +{ >> + unsigned int tmp; >> + >> + pr_info("Power down.\n"); >> + tmp = pmu_raw_readl(EXYNOS_PS_HOLD_CONTROL); >> + tmp ^= (1 << 8); > Can we have some define over here? to operate this bit. > 1. This will be removed by syscon-reboot/poweroff patches [0]. 2. This patch is only rename/move. Fixing stuff should go to separate patches. But IMHO fixing is not needed because of 1. [0] http://www.spinics.net/lists/devicetree/msg98858.html Best regards, Krzysztof