From: "Andrew F. Davis" <afd@ti.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
"Sebastian Reichel" <sre@kernel.org>,
"Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
"David Woodhouse" <dwmw2@infradead.org>,
"Andreas Dannenberg" <dannenberg@ti.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: bq27xxx_battery: Reorganize I2C into a module
Date: Mon, 23 Nov 2015 11:09:50 -0600 [thread overview]
Message-ID: <5653485E.70005@ti.com> (raw)
In-Reply-To: <3809374.hKy9fQ2ldj@wuerfel>
On 11/23/2015 10:57 AM, Arnd Bergmann wrote:
> On Monday 23 November 2015 10:53:51 Andrew F. Davis wrote:
>> Separate out I2C functionality into a module. This fixes several small
>> issues and simplifies the driver initialization.
>>
>> Signed-off-by: Andrew F. Davis <afd@ti.com>
>
> That looks good to me overall, it should help with the randconfig
> warnings I've been seeing and makes the driver structured more logically.
>
> The one part I wonder about is whether the platform_driver portion
> should also be split out into a separate module in the same way.
>
> Arnd
>
I think it should, I'm just waiting until I can find some time to
bring up regmap for 1wire, then I can really clean things up and
move the platform stuff (which is really the 1wire interface) out
more cleanly, all I'll need to do then is just pass a regmap handle
to the core from the interface modules.
But that's all a project for another day :)
next prev parent reply other threads:[~2015-11-23 17:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 16:53 [PATCH] power: bq27xxx_battery: Reorganize I2C into a module Andrew F. Davis
2015-11-23 16:57 ` Arnd Bergmann
2015-11-23 17:09 ` Andrew F. Davis [this message]
2015-11-23 19:26 ` Arnd Bergmann
2015-12-05 1:14 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5653485E.70005@ti.com \
--to=afd@ti.com \
--cc=arnd@arndb.de \
--cc=dannenberg@ti.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).