From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v4 7/8] ARM: dts: Exynos5422: fix OPP tables Date: Wed, 09 Dec 2015 09:34:09 +0900 Message-ID: <56677701.10809@samsung.com> References: <1449512300-17230-1-git-send-email-b.zolnierkie@samsung.com> <1449512300-17230-8-git-send-email-b.zolnierkie@samsung.com> <56669126.7050803@samsung.com> <5666DE25.7090708@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.w1.samsung.com ([210.118.77.14]:27028 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751934AbbLIAeU (ORCPT ); Tue, 8 Dec 2015 19:34:20 -0500 In-reply-to: <5666DE25.7090708@osg.samsung.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Javier Martinez Canillas , Bartlomiej Zolnierkiewicz , Thomas Abraham , Sylwester Nawrocki , Mike Turquette , Kukjin Kim , Kukjin Kim , Viresh Kumar , Ben Gamari Cc: Tomasz Figa , Lukasz Majewski , Heiko Stuebner , Chanwoo Choi , Kevin Hilman , Tobias Jakobi , Anand Moon , linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org On 08.12.2015 22:41, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 12/08/2015 05:13 AM, Krzysztof Kozlowski wrote: >> On 08.12.2015 03:18, Bartlomiej Zolnierkiewicz wrote: >>> From: Ben Gamari >>> >>> The Exynos 5422 is identical to the 5800 except for the fact that it >>> boots from the A7 cores. Consequently, the core numbering is different: >>> cores 0-3 are A7s whereas 4-7 are A15s. >>> >>> We can reuse the device tree of the 5800 for the 5422 but we must take >>> care to override the OPP tables and CPU clocks. These are otherwise >>> inherited from the exynos5800 devicetree, which has the CPU clusters >>> reversed compared to the 5422. This results in the A15 cores only >>> reaching 1.4GHz, the maximum rate of the KFC clock. >>> >>> Cc: Javier Martinez Canillas >>> Signed-off-by: Ben Gamari >>> Signed-off-by: Bartlomiej Zolnierkiewicz >>> --- >>> arch/arm/boot/dts/exynos5422-cpus.dtsi | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> >> >> This looks like a very-non-atomic way of handling a change. You added >> opp tables to exynos5420 before so at that time they will be applied to >> Odroid XU3 family which uses different CPU order. After that you are >> fixing the tables to proper CPU order. Direct bisectability probably >> won't be an issue because all of DTS would go to separate branch... but >> the logic behind confuses. >> > > Agreed. > >> I think this should be squashed into 3/8. >> > > I think the patch should be split in two changes, the CPUs device nodes > having the wrong clock for clusters is a bug and has to be fixed in a > patch before adding the OPP tables and the OPP tables changes should be > separated and merged with patch 3/8 as you suggest. I don't get the point about wrong clock (bug). Where is the bug? Beside of course what was introduced in 3/8 and it is not valid for reversed cluster order. Best regards, Krzysztof