linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Richard Weinberger <richard@nod.at>, linux-kernel@vger.kernel.org
Cc: user-mode-linux-devel@lists.sourceforge.net,
	Sebastian Reichel <sre@kernel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Moritz Fischer <moritz.fischer@ettus.com>,
	Jun Nie <jun.nie@linaro.org>,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH 01/22] power: reset: Fix dependencies for !HAS_IOMEM archs
Date: Tue, 26 Jan 2016 15:34:07 -0800	[thread overview]
Message-ID: <56A8026F.8090001@gmail.com> (raw)
In-Reply-To: <1453760661-1444-2-git-send-email-richard@nod.at>

On 25/01/16 14:24, Richard Weinberger wrote:
> Not every arch has io memory.
> So, unbreak the build by fixing the dependencies.
> 
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
>  drivers/power/reset/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> index 1131cf7..0a6408a 100644
> --- a/drivers/power/reset/Kconfig
> +++ b/drivers/power/reset/Kconfig
> @@ -148,6 +148,7 @@ config POWER_RESET_KEYSTONE
>  config POWER_RESET_SYSCON
>  	bool "Generic SYSCON regmap reset driver"
>  	depends on OF
> +	depends on HAS_IOMEM
>  	select MFD_SYSCON

Should this dependency go into REGMAP_MMIO instead? MFD_SYSCON in itself
does not issue I/O accesses per-se, but does use helpers from regmap,
which in turn do it.

>  	help
>  	  Reboot support for generic SYSCON mapped register reset.
> @@ -155,6 +156,7 @@ config POWER_RESET_SYSCON
>  config POWER_RESET_SYSCON_POWEROFF
>  	bool "Generic SYSCON regmap poweroff driver"
>  	depends on OF
> +	depends on HAS_IOMEM
>  	select MFD_SYSCON

Likewise.
-- 
Florian

  reply	other threads:[~2016-01-26 23:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1453760661-1444-1-git-send-email-richard@nod.at>
2016-01-25 22:24 ` [PATCH 01/22] power: reset: Fix dependencies for !HAS_IOMEM archs Richard Weinberger
2016-01-26 23:34   ` Florian Fainelli [this message]
2016-01-27  8:02     ` Richard Weinberger
2016-02-15  5:57   ` Sebastian Reichel
2016-01-25 22:24 ` [PATCH 19/22] thermal: " Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56A8026F.8090001@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=dbaryshkov@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=jun.nie@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=moritz.fischer@ettus.com \
    --cc=richard@nod.at \
    --cc=sre@kernel.org \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).