[PATCH 01/22] power: reset: Fix dependencies for !HAS

linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH 01/22] power: reset: Fix dependencies for !HAS_IOMEM archs
       [not found] <1453760661-1444-1-git-send-email-richard@nod.at>
@ 2016-01-25 22:24 ` Richard Weinberger
  2016-01-26 23:34   ` Florian Fainelli
  2016-02-15  5:57   ` Sebastian Reichel
  2016-01-25 22:24 ` [PATCH 19/22] thermal: " Richard Weinberger
  1 sibling, 2 replies; 5+ messages in thread
From: Richard Weinberger @ 2016-01-25 22:24 UTC (permalink / raw)
  To: linux-kernel
  Cc: user-mode-linux-devel, Richard Weinberger, Sebastian Reichel,
	Dmitry Eremin-Solenikov, David Woodhouse, Alexandre Belloni,
	Moritz Fischer, Florian Fainelli, Jun Nie, linux-pm

Not every arch has io memory.
So, unbreak the build by fixing the dependencies.

Signed-off-by: Richard Weinberger <richard@nod.at>
---
 drivers/power/reset/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
index 1131cf7..0a6408a 100644
--- a/drivers/power/reset/Kconfig
+++ b/drivers/power/reset/Kconfig
@@ -148,6 +148,7 @@ config POWER_RESET_KEYSTONE
 config POWER_RESET_SYSCON
 	bool "Generic SYSCON regmap reset driver"
 	depends on OF
+	depends on HAS_IOMEM
 	select MFD_SYSCON
 	help
 	  Reboot support for generic SYSCON mapped register reset.
@@ -155,6 +156,7 @@ config POWER_RESET_SYSCON
 config POWER_RESET_SYSCON_POWEROFF
 	bool "Generic SYSCON regmap poweroff driver"
 	depends on OF
+	depends on HAS_IOMEM
 	select MFD_SYSCON
 	help
 	  Poweroff support for generic SYSCON mapped register poweroff.
-- 
1.8.4.5


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 01/22] power: reset: Fix dependencies for !HAS_IOMEM archs
  2016-01-25 22:24 ` [PATCH 01/22] power: reset: Fix dependencies for !HAS_IOMEM archs Richard Weinberger
@ 2016-01-26 23:34   ` Florian Fainelli
  2016-01-27  8:02     ` Richard Weinberger
  2016-02-15  5:57   ` Sebastian Reichel
  1 sibling, 1 reply; 5+ messages in thread
From: Florian Fainelli @ 2016-01-26 23:34 UTC (permalink / raw)
  To: Richard Weinberger, linux-kernel
  Cc: user-mode-linux-devel, Sebastian Reichel, Dmitry Eremin-Solenikov,
	David Woodhouse, Alexandre Belloni, Moritz Fischer, Jun Nie,
	linux-pm

On 25/01/16 14:24, Richard Weinberger wrote:
> Not every arch has io memory.
> So, unbreak the build by fixing the dependencies.
> 
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
>  drivers/power/reset/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> index 1131cf7..0a6408a 100644
> --- a/drivers/power/reset/Kconfig
> +++ b/drivers/power/reset/Kconfig
> @@ -148,6 +148,7 @@ config POWER_RESET_KEYSTONE
>  config POWER_RESET_SYSCON
>  	bool "Generic SYSCON regmap reset driver"
>  	depends on OF
> +	depends on HAS_IOMEM
>  	select MFD_SYSCON

Should this dependency go into REGMAP_MMIO instead? MFD_SYSCON in itself
does not issue I/O accesses per-se, but does use helpers from regmap,
which in turn do it.

>  	help
>  	  Reboot support for generic SYSCON mapped register reset.
> @@ -155,6 +156,7 @@ config POWER_RESET_SYSCON
>  config POWER_RESET_SYSCON_POWEROFF
>  	bool "Generic SYSCON regmap poweroff driver"
>  	depends on OF
> +	depends on HAS_IOMEM
>  	select MFD_SYSCON

Likewise.
-- 
Florian

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 01/22] power: reset: Fix dependencies for !HAS_IOMEM archs
  2016-01-26 23:34   ` Florian Fainelli
@ 2016-01-27  8:02     ` Richard Weinberger
  0 siblings, 0 replies; 5+ messages in thread
From: Richard Weinberger @ 2016-01-27  8:02 UTC (permalink / raw)
  To: Florian Fainelli, linux-kernel
  Cc: user-mode-linux-devel, Sebastian Reichel, Dmitry Eremin-Solenikov,
	David Woodhouse, Alexandre Belloni, Moritz Fischer, Jun Nie,
	linux-pm

Am 27.01.2016 um 00:34 schrieb Florian Fainelli:
> On 25/01/16 14:24, Richard Weinberger wrote:
>> Not every arch has io memory.
>> So, unbreak the build by fixing the dependencies.
>>
>> Signed-off-by: Richard Weinberger <richard@nod.at>
>> ---
>>  drivers/power/reset/Kconfig | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
>> index 1131cf7..0a6408a 100644
>> --- a/drivers/power/reset/Kconfig
>> +++ b/drivers/power/reset/Kconfig
>> @@ -148,6 +148,7 @@ config POWER_RESET_KEYSTONE
>>  config POWER_RESET_SYSCON
>>  	bool "Generic SYSCON regmap reset driver"
>>  	depends on OF
>> +	depends on HAS_IOMEM
>>  	select MFD_SYSCON
> 
> Should this dependency go into REGMAP_MMIO instead? MFD_SYSCON in itself
> does not issue I/O accesses per-se, but does use helpers from regmap,
> which in turn do it.

Hmmm, AFAICT this would not work as REGMAP_MMIO is not user visible and directly enabled
via "select" instead of "depends on". Hence, dependencies are ignored.

Thanks,
//richard

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 01/22] power: reset: Fix dependencies for !HAS_IOMEM archs
  2016-01-25 22:24 ` [PATCH 01/22] power: reset: Fix dependencies for !HAS_IOMEM archs Richard Weinberger
  2016-01-26 23:34   ` Florian Fainelli
@ 2016-02-15  5:57   ` Sebastian Reichel
  1 sibling, 0 replies; 5+ messages in thread
From: Sebastian Reichel @ 2016-02-15  5:57 UTC (permalink / raw)
  To: Richard Weinberger
  Cc: linux-kernel, user-mode-linux-devel, Dmitry Eremin-Solenikov,
	David Woodhouse, Alexandre Belloni, Moritz Fischer,
	Florian Fainelli, Jun Nie, linux-pm

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

Hi,

On Mon, Jan 25, 2016 at 11:24:00PM +0100, Richard Weinberger wrote:
> Not every arch has io memory.
> So, unbreak the build by fixing the dependencies.

Thanks, queued.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 19/22] thermal: Fix dependencies for !HAS_IOMEM archs
       [not found] <1453760661-1444-1-git-send-email-richard@nod.at>
  2016-01-25 22:24 ` [PATCH 01/22] power: reset: Fix dependencies for !HAS_IOMEM archs Richard Weinberger
@ 2016-01-25 22:24 ` Richard Weinberger
  1 sibling, 0 replies; 5+ messages in thread
From: Richard Weinberger @ 2016-01-25 22:24 UTC (permalink / raw)
  To: linux-kernel
  Cc: user-mode-linux-devel, linux-pm, Richard Weinberger,
	Eduardo Valentin, Zhang Rui, linux-omap

Not every arch has io memory.
So, unbreak the build by fixing the dependencies.

Signed-off-by: Richard Weinberger <richard@nod.at>
---
 drivers/thermal/Kconfig                | 7 +++++++
 drivers/thermal/ti-soc-thermal/Kconfig | 1 +
 2 files changed, 8 insertions(+)

diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 8cc4ac6..8876c7e 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -178,6 +178,7 @@ config THERMAL_EMULATION
 config HISI_THERMAL
 	tristate "Hisilicon thermal driver"
 	depends on (ARCH_HISI && CPU_THERMAL && OF) || COMPILE_TEST
+	depends on HAS_IOMEM
 	help
 	  Enable this to plug hisilicon's thermal sensor driver into the Linux
 	  thermal framework. cpufreq is used as the cooling device to throttle
@@ -198,6 +199,7 @@ config SPEAR_THERMAL
 	bool "SPEAr thermal sensor driver"
 	depends on PLAT_SPEAR || COMPILE_TEST
 	depends on OF
+	depends on HAS_IOMEM
 	help
 	  Enable this to plug the SPEAr thermal sensor driver into the Linux
 	  thermal framework.
@@ -206,6 +208,7 @@ config ROCKCHIP_THERMAL
 	tristate "Rockchip thermal driver"
 	depends on ARCH_ROCKCHIP || COMPILE_TEST
 	depends on RESET_CONTROLLER
+	depends on HAS_IOMEM
 	help
 	  Rockchip thermal driver provides support for Temperature sensor
 	  ADC (TS-ADC) found on Rockchip SoCs. It supports one critical
@@ -224,6 +227,7 @@ config KIRKWOOD_THERMAL
 	tristate "Temperature sensor on Marvell Kirkwood SoCs"
 	depends on MACH_KIRKWOOD || COMPILE_TEST
 	depends on OF
+	depends on HAS_IOMEM
 	help
 	  Support for the Kirkwood thermal sensor driver into the Linux thermal
 	  framework. Only kirkwood 88F6282 and 88F6283 have this sensor.
@@ -232,6 +236,7 @@ config DOVE_THERMAL
 	tristate "Temperature sensor on Marvell Dove SoCs"
 	depends on ARCH_DOVE || MACH_DOVE || COMPILE_TEST
 	depends on OF
+	depends on HAS_IOMEM
 	help
 	  Support for the Dove thermal sensor driver in the Linux thermal
 	  framework.
@@ -250,6 +255,7 @@ config ARMADA_THERMAL
 	tristate "Armada 370/XP thermal management"
 	depends on ARCH_MVEBU || COMPILE_TEST
 	depends on OF
+	depends on HAS_IOMEM
 	help
 	  Enable this option if you want to have support for thermal management
 	  controller present in Armada 370 and Armada XP SoC.
@@ -372,6 +378,7 @@ endmenu
 
 menu "Samsung thermal drivers"
 depends on ARCH_EXYNOS || COMPILE_TEST
+depends on HAS_IOMEM
 source "drivers/thermal/samsung/Kconfig"
 endmenu
 
diff --git a/drivers/thermal/ti-soc-thermal/Kconfig b/drivers/thermal/ti-soc-thermal/Kconfig
index ea8283f..283d794 100644
--- a/drivers/thermal/ti-soc-thermal/Kconfig
+++ b/drivers/thermal/ti-soc-thermal/Kconfig
@@ -1,5 +1,6 @@
 config TI_SOC_THERMAL
 	tristate "Texas Instruments SoCs temperature sensor driver"
+	depends on HAS_IOMEM
 	help
 	  If you say yes here you get support for the Texas Instruments
 	  OMAP4460+ on die bandgap temperature sensor support. The register
-- 
1.8.4.5


------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-02-15  5:57 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1453760661-1444-1-git-send-email-richard@nod.at>
2016-01-25 22:24 ` [PATCH 01/22] power: reset: Fix dependencies for !HAS_IOMEM archs Richard Weinberger
2016-01-26 23:34   ` Florian Fainelli
2016-01-27  8:02     ` Richard Weinberger
2016-02-15  5:57   ` Sebastian Reichel
2016-01-25 22:24 ` [PATCH 19/22] thermal: " Richard Weinberger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).