* [PATCH 0/1] account I/O Wait during synchronous write
@ 2016-02-09 16:07 Stephane Gasparini
2016-02-09 16:07 ` [PATCH 1/1] kernel/fs: fix I/O wait not accounted for RW O_DSYNC Stephane Gasparini
0 siblings, 1 reply; 3+ messages in thread
From: Stephane Gasparini @ 2016-02-09 16:07 UTC (permalink / raw)
To: linux-block, linux-pm, lenb, srinivas.pandruvada
Cc: Stephane Gasparini, len.brown, philippe.longepe
From: Stephane Gasparini <stephane.gasparini@linux.intel.com>
This patch allow to take into account I/O wait for synchronous write
Stephane Gasparini (1):
kernel/fs: fix I/O wait not accounted for RW O_DSYNC
block/bio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
Stephane Gasparini<stephane.gasparini@linux.intel.com>
---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris,
92196 Meudon Cedex, France
Registration Number: 302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] kernel/fs: fix I/O wait not accounted for RW O_DSYNC
2016-02-09 16:07 [PATCH 0/1] account I/O Wait during synchronous write Stephane Gasparini
@ 2016-02-09 16:07 ` Stephane Gasparini
2016-02-09 16:27 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: Stephane Gasparini @ 2016-02-09 16:07 UTC (permalink / raw)
To: linux-block, linux-pm, lenb, srinivas.pandruvada
Cc: Stephane Gasparini, len.brown, philippe.longepe
From: Stephane Gasparini <stephane.gasparini@linux.intel.com>
When a process is doing Random Write with O_DSYNC flag
the I/O wait are not accounted in the kernel (get_cpu_iowait_time_us).
This is preventing the governor or the cpufreq driver to account for
I/O wait and thus use the right pstate
Signed-off-by: Stephane Gasparini <stephane.gasparini@linux.intel.com>
Signed-off-by: Philippe Longepe <philippe.longepe@linux.intel.com>
---
block/bio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/bio.c b/block/bio.c
index dbabd48b1934..f53a691b6533 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -874,7 +874,7 @@ int submit_bio_wait(int rw, struct bio *bio)
bio->bi_private = &ret;
bio->bi_end_io = submit_bio_wait_endio;
submit_bio(rw, bio);
- wait_for_completion(&ret.event);
+ wait_for_completion_io(&ret.event);
return ret.error;
}
--
Stephane Gasparini<stephane.gasparini@linux.intel.com>
---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris,
92196 Meudon Cedex, France
Registration Number: 302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] kernel/fs: fix I/O wait not accounted for RW O_DSYNC
2016-02-09 16:07 ` [PATCH 1/1] kernel/fs: fix I/O wait not accounted for RW O_DSYNC Stephane Gasparini
@ 2016-02-09 16:27 ` Jens Axboe
0 siblings, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2016-02-09 16:27 UTC (permalink / raw)
To: Stephane Gasparini, linux-block, linux-pm, lenb,
srinivas.pandruvada
Cc: Stephane Gasparini, len.brown, philippe.longepe
On 02/09/2016 09:07 AM, Stephane Gasparini wrote:
> From: Stephane Gasparini <stephane.gasparini@linux.intel.com>
>
> When a process is doing Random Write with O_DSYNC flag
> the I/O wait are not accounted in the kernel (get_cpu_iowait_time_us).
> This is preventing the governor or the cpufreq driver to account for
> I/O wait and thus use the right pstate
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-09 16:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-09 16:07 [PATCH 0/1] account I/O Wait during synchronous write Stephane Gasparini
2016-02-09 16:07 ` [PATCH 1/1] kernel/fs: fix I/O wait not accounted for RW O_DSYNC Stephane Gasparini
2016-02-09 16:27 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).