From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 3/3] thermal: exynos: Defer probe if vtmu is present but not registered Date: Fri, 19 Feb 2016 09:37:00 +0900 Message-ID: <56C663AC.7030601@samsung.com> References: <1455819551-4666-1-git-send-email-javier@osg.samsung.com> <1455819551-4666-4-git-send-email-javier@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <1455819551-4666-4-git-send-email-javier@osg.samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Javier Martinez Canillas , linux-kernel@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, Kukjin Kim , linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Lukasz Majewski , Zhang Rui , Eduardo Valentin List-Id: linux-pm@vger.kernel.org On 19.02.2016 03:19, Javier Martinez Canillas wrote: > The driver doesn't check if the regulator_get_optional return value is > -EPROBE_DEFER so it will wrongly assume that the regulator couldn't be > found just because the regulator driver wasn't registered yet, i.e: > > exynos-tmu 10060000.tmu: Regulator node (vtmu) not found > > In this case the return value should be propagated to allow the driver > probe function to be deferred until the regulator driver is registered. > > Signed-off-by: Javier Martinez Canillas > > --- > > drivers/thermal/samsung/exynos_tmu.c | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof