From: Caesar Wang <caesar.upstream@gmail.com>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Heiko Stuebner <heiko@sntech.de>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org,
Caesar Wang <wxt@rock-chips.com>
Subject: Re: [PATCH] thermal: rockchip: disable thermal->clk in err case
Date: Thu, 3 Mar 2016 11:34:40 +0800 [thread overview]
Message-ID: <56D7B0D0.7090605@gmail.com> (raw)
In-Reply-To: <1455503242-19907-1-git-send-email-shawn.lin@rock-chips.com>
Hi ,
Sorry for the missing it.
在 2016年02月15日 10:27, Shawn Lin 写道:
> Disable thermal->clk when enabling pclk fails in
> resume routine.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Reviewed-by: Caesar Wang <wxt@rock-chips.com>
> ---
>
> drivers/thermal/rockchip_thermal.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c
> index 9787e8a..b54f6db 100644
> --- a/drivers/thermal/rockchip_thermal.c
> +++ b/drivers/thermal/rockchip_thermal.c
> @@ -656,8 +656,10 @@ static int __maybe_unused rockchip_thermal_resume(struct device *dev)
> return error;
>
> error = clk_enable(thermal->pclk);
> - if (error)
> + if (error) {
> + clk_disable(thermal->clk);
> return error;
> + }
>
> rockchip_thermal_reset_controller(thermal->reset);
>
--
Thanks,
Caesar
prev parent reply other threads:[~2016-03-03 3:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 2:27 [PATCH] thermal: rockchip: disable thermal->clk in err case Shawn Lin
2016-03-01 11:48 ` Heiko Stübner
2016-03-03 3:34 ` Caesar Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D7B0D0.7090605@gmail.com \
--to=caesar.upstream@gmail.com \
--cc=edubezval@gmail.com \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=rui.zhang@intel.com \
--cc=shawn.lin@rock-chips.com \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).