From: Laxman Dewangan <ldewangan@nvidia.com>
To: Eduardo Valentin <edubezval@gmail.com>
Cc: rui.zhang@intel.com, robh+dt@kernel.org, mark.rutland@arm.com,
corbet@lwn.net, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, rklein@nvidia.com
Subject: Re: [PATCH V2 5/6] thermal: max77620: Add thermal driver for reporting junction temp
Date: Thu, 10 Mar 2016 12:26:24 +0530 [thread overview]
Message-ID: <56E11A98.4000000@nvidia.com> (raw)
In-Reply-To: <20160309192751.GB2422@localhost.localdomain>
On Thursday 10 March 2016 12:57 AM, Eduardo Valentin wrote:
> * PGP Signed by an unknown key
>
> On Wed, Mar 09, 2016 at 06:40:09PM +0530, Laxman Dewangan wrote:
>> Maxim Semiconductor Max77620 supports alarm interrupts when
>> its die temperature crosses 120C and 140C. These threshold
>> temperatures are not configurable.
>>
>> Add thermal driver to register PMIC die temperature as thermal
>> zone sensor and capture the die temperature warning interrupts
>> to notifying the client.
>>
>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
>>
>> ---
>> Changes from V1:
>> - checkpatch warning fix and simplifying the dev.of_node
>> initialisation.
>>
>> drivers/thermal/Kconfig | 10 +++
>> drivers/thermal/Makefile | 1 +
>> drivers/thermal/thermal-max77620.c | 151 +++++++++++++++++++++++++++++++++++++
>> 3 files changed, 162 insertions(+)
>> create mode 100644 drivers/thermal/thermal-max77620.c
>>
>> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
>> index 5e7c97a..fc856eb 100644
>> --- a/drivers/thermal/Kconfig
>> +++ b/drivers/thermal/Kconfig
>> @@ -194,6 +194,16 @@ config IMX_THERMAL
>> cpufreq is used as the cooling device to throttle CPUs when the
>> passive trip is crossed.
>>
>> +config MAX77620_THERMAL
>> + tristate "Temperature sensor driver for Maxim MAX77620 PMIC"
>> + depends on MFD_MAX77620
>> + depends on OF
> The previous question on compile test was more if we could add depends
> on COMPILE_TEST flag. Sorry if I was not clear enough.
>
>
> I am adding the flag here:
>
>
> config MAX77620_THERMAL
> tristate "Temperature sensor driver for Maxim MAX77620 PMIC"
> - depends on MFD_MAX77620
> + depends on MFD_MAX77620 || COMPILE_TEST
> + depends on HAS_IOMEM
> depends on OF
> help
> Support for die junction temperature
> warning alarm for Maxim
>
>
> but I still cannot compile test the file because of the missing header.
> drivers/thermal/thermal-max77620.c:16:32: fatal error:
> linux/mfd/max77620.h: No such file or directory
> #include <linux/mfd/max77620.h>
>
>
> I wont be able to merge this as it is. We need to sort out the
> dependency first.
>
I will update you once the mfd patches will merge as this header is on
that patch.
next prev parent reply other threads:[~2016-03-10 6:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 13:10 [PATCH V2 0/6] thermal: add devm_ version of thermal_zone register and driver for max77620 Laxman Dewangan
2016-03-09 13:10 ` [PATCH V2 1/6] thermal: doc: Add details of thermal_zone_of_sensor_{register,unregister} Laxman Dewangan
2016-03-09 13:10 ` [PATCH V2 2/6] thermal: of-thermal: Add devm version of thermal_zone_of_sensor_register Laxman Dewangan
2016-03-09 13:10 ` [PATCH V2 3/6] thermal: Add devm_thermal_zone_of_sensor_register() in managed devices list Laxman Dewangan
2016-03-09 19:31 ` Eduardo Valentin
[not found] ` <1457529010-6538-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-09 13:10 ` [PATCH V2 4/6] thermal: doc: Add details of devm_thermal_zone_of_sensor_{register,unregister} Laxman Dewangan
2016-03-09 13:10 ` [PATCH V2 5/6] thermal: max77620: Add thermal driver for reporting junction temp Laxman Dewangan
2016-03-09 19:27 ` Eduardo Valentin
2016-03-10 6:56 ` Laxman Dewangan [this message]
2016-03-09 13:10 ` [PATCH V2 6/6] thermal: Add DT binding doc for thermal of PMIC max77620 Laxman Dewangan
2016-03-09 19:29 ` Eduardo Valentin
2016-03-09 18:29 ` [PATCH V2 0/6] thermal: add devm_ version of thermal_zone register and driver for max77620 Eduardo Valentin
2016-03-09 19:32 ` Eduardo Valentin
[not found] ` <20160309193249.GE2422-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2016-03-10 6:55 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E11A98.4000000@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rklein@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).