From: Matt Longnecker <mlongnecker@nvidia.com>
To: Srikar Srimath Tirumala <srikars@nvidia.com>,
edubezval@gmail.com, rui.zhang@intel.com,
srinivas.pandruvada@intel.com, linux-pm@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH v3 2/4] thermal: send notifications for tz temperature
Date: Wed, 30 Mar 2016 09:53:37 -0700 [thread overview]
Message-ID: <56FC0491.10309@nvidia.com> (raw)
In-Reply-To: <56FC0215.1060802@nvidia.com>
On 03/30/2016 09:43 AM, Matt Longnecker wrote:
>
>
> On 03/29/2016 05:41 PM, Srikar Srimath Tirumala wrote:
>> struct thermal_trip {
>> @@ -355,6 +366,7 @@ struct thermal_trip {
>> unsigned long int temperature;
>> unsigned long int hysteresis;
>> enum thermal_trip_type type;
>> + enum thermal_trip_state state;
> This looks vestigial. Remove it?
>
>
nevermind. I see that it's used in the next patch. And it really does
belong here, not in the next patch.
next prev parent reply other threads:[~2016-03-30 16:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 0:41 [PATCH v3 0/4] add sysfs_notify on some attributes Srikar Srimath Tirumala
2016-03-30 0:41 ` [PATCH v3 2/4] thermal: send notifications for tz temperature Srikar Srimath Tirumala
[not found] ` <1459298497-29481-3-git-send-email-srikars-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-30 16:43 ` Matt Longnecker
2016-03-30 16:53 ` Matt Longnecker [this message]
[not found] ` <1459298497-29481-1-git-send-email-srikars-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-30 0:41 ` [PATCH v3 1/4] thermal: send notifications for cdev state change Srikar Srimath Tirumala
[not found] ` <1459298497-29481-2-git-send-email-srikars-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-30 16:45 ` Matt Longnecker
2016-03-30 0:41 ` [PATCH v3 3/4] thermal: of: enable temperature notifications Srikar Srimath Tirumala
2016-03-30 16:54 ` Matt Longnecker
[not found] ` <1459298497-29481-4-git-send-email-srikars-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-05-03 3:26 ` Eduardo Valentin
2016-03-30 0:41 ` [PATCH v3 4/4] thermal: update documentation for new device ops Srikar Srimath Tirumala
[not found] ` <1459298497-29481-5-git-send-email-srikars-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-30 16:54 ` Matt Longnecker
2016-05-03 3:27 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FC0491.10309@nvidia.com \
--to=mlongnecker@nvidia.com \
--cc=edubezval@gmail.com \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=srikars@nvidia.com \
--cc=srinivas.pandruvada@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).