From: "Andrew F. Davis" <afd@ti.com>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-pm@vger.kernel.org, Pavel Machek <pavel@ucw.cz>
Subject: Re: Should 9aafabc7fece be reverted?
Date: Thu, 19 May 2016 11:11:14 -0500 [thread overview]
Message-ID: <573DE5A2.7070900@ti.com> (raw)
In-Reply-To: <201605191806.50809@pali>
On 05/19/2016 11:06 AM, Pali Rohár wrote:
> On Thursday 19 May 2016 17:57:34 Andrew F. Davis wrote:
>> On 05/19/2016 10:51 AM, Pali Rohár wrote:
>>> On Thursday 19 May 2016 17:48:29 Andrew F. Davis wrote:
>>>> On 05/19/2016 10:44 AM, Pali Rohár wrote:
>>>>> On Thursday 19 May 2016 17:38:14 Andrew F. Davis wrote:
>>>>>> P.S. The code is still a bit strange, I'll probably go grab one
>>>>>> of the N900s from our test farm and make sure my future
>>>>>> cleanups don't break this, but are we sure the *name* of a
>>>>>> driver is an ABI?
>>>>>
>>>>> It is not name of driver, but directory name of sysfs path where
>>>>> device is exported...
>>>>
>>>> Which is named after the drivers name, so the same question
>>>> remains.
>>>>
>>>> :/
>>>
>>> No, it is not driver name, but device name. That is different.
>>
>> My bad, that's what I meant, device names should be dynamic, right?
>> Relying on them being static in software would then be buggy (like
>> relying on eth0 being the right NIC everytime)?
>>
>> I'm not familiar with the N900 software, but IDR can give out
>> different numbers and may not always give the first battery #0 (it
>> does now but is that a guarantee in IDR?) and if not then what is
>> the userspace response to this changing?
>
> In case N900 would have more bq27xxx batteries, then yes. But N900 has
> exactly *one* bq27200 battery, so there is no IDR problem.
>
Right, but if IDR returns 42 instead of 0 would this then break its
userspace software?
How is this handled for other power-supply drivers when more that one
battery exists, they look to give static device names so I'm assuming
the framework handles giving them new folder names automatically.
next prev parent reply other threads:[~2016-05-19 16:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 16:58 Should 9aafabc7fece be reverted? Andrew F. Davis
2016-05-19 6:44 ` Ivaylo Dimitrov
2016-05-19 9:17 ` Pali Rohár
2016-05-19 9:34 ` Ivaylo Dimitrov
2016-05-19 15:38 ` Andrew F. Davis
2016-05-19 15:44 ` Pali Rohár
2016-05-19 15:48 ` Andrew F. Davis
2016-05-19 15:51 ` Pali Rohár
2016-05-19 15:57 ` Andrew F. Davis
2016-05-19 16:06 ` Pali Rohár
2016-05-19 16:11 ` Andrew F. Davis [this message]
2016-05-19 16:18 ` Pali Rohár
2016-05-19 16:46 ` Andrew F. Davis
2016-05-20 9:29 ` Pavel Machek
2016-05-23 15:55 ` Andrew F. Davis
2016-05-23 16:10 ` Pali Rohár
2016-05-23 16:29 ` Andrew F. Davis
2016-05-20 9:34 ` Pavel Machek
2016-05-20 10:35 ` Pali Rohár
2016-05-23 16:05 ` Andrew F. Davis
2016-05-20 9:22 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573DE5A2.7070900@ti.com \
--to=afd@ti.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-pm@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).