From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [patch v2] PM / devfreq: exynos-nocp: Remove incorrect IS_ERR() check Date: Thu, 26 May 2016 19:16:03 +0900 Message-ID: <5746CCE3.5010701@samsung.com> References: <20160526064541.GA6680@mwanda> <5746AFE3.6030606@samsung.com> <20160526100238.GN11011@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-reply-to: <20160526100238.GN11011@mwanda> Sender: linux-samsung-soc-owner@vger.kernel.org To: Dan Carpenter Cc: Julia Lawall , MyungJoo Ham , Kyungmin Park , Kukjin Kim , Krzysztof Kozlowski , linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, kernel-janitors@vger.kernel.org List-Id: linux-pm@vger.kernel.org On 2016=EB=85=84 05=EC=9B=94 26=EC=9D=BC 19:02, Dan Carpenter wrote: > On Thu, May 26, 2016 at 05:12:19PM +0900, Chanwoo Choi wrote: >> I don't recommend that you mention the name of engineer on patch des= cription >> directly. Except for this comment, looks good to me. >=20 > I always feel it's nicer to give credit. Plus Julia is already a wel= l > known kernel dev and this was a pubic list. (I wouldn't give credit = if > she had sent hurtful comments about my spelling to me privately, for > example). If you want to give credit as you mentioned, you can add the acked-by or signed-off for Julia. But, usually, the patch description don't include the engineer's name directly. Thanks, Chanwoo Choi