From: Chanwoo Choi <cw00.choi@samsung.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: dbaryshkov@gmail.com, dwmw2@infradead.org, wens@csie.org,
myungjoo.ham@samsung.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] power: axp288_charger: Replace deprecatd API of extcon
Date: Fri, 10 Jun 2016 10:51:40 +0900 [thread overview]
Message-ID: <575A1D2C.5060101@samsung.com> (raw)
In-Reply-To: <20160610014643.GC5848@earth>
Hi,
On 2016년 06월 10일 10:46, Sebastian Reichel wrote:
> Hi,
>
> On Tue, May 31, 2016 at 06:34:39PM +0900, Chanwoo Choi wrote:
>> This patch removes the deprecated notifier API of extcon framework and then use
>> the new extcon API[2] with the unique id[1] to indicate the each external
>> connector. Alter deprecated API as following:
>> - extcon_register_interest() -> extcon_register_notifier()
>> - extcon_unregister_interest() -> extcon_unregister_notifier()
>> - extcon_get_cable_state() -> extcon_get_cable_state_()
>>
>> And, extcon alters the name of USB charger connector in patch[3] as following:
>> - EXTCON_CHG_USB_SDP /* Standard Downstream Port */
>> - EXTCON_CHG_USB_DCP /* Dedicated Charging Port */
>> - EXTCON_CHG_USB_CDP /* Charging Downstream Port */
>> - EXTCON_CHG_USB_ACA /* Accessory Charger Adapter */
>>
>> [1] Commit 2a9de9c0f08d61
>> - ("extcon: Use the unique id for external connector instead of string)
>> [2] Commit 046050f6e623e4
>> - ("extcon: Update the prototype of extcon_register_notifier() with enum extcon
>> [3] Commit 11eecf910bd81d
>> - ("extcon: Modify the id and name of external connector")
>>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> ---
>> drivers/power/axp288_charger.c | 77 +++++++++++++++++++++++++++++-------------
>> 1 file changed, 53 insertions(+), 24 deletions(-)
>
> Acked-By: Sebastian Reichel <sre@kernel.org>
>
To prevent the build error on linux-next, this patchset should be merged on one repository.
So, I think that there are two solution.
First, I'll make the immutable branch for them and send pull request to you.
Second, I'll apply this patchset on extcon git repository.
Which would you prefer? If you answer, I'll do right now.
Thanks,
Chanwoo Choi
next prev parent reply other threads:[~2016-06-10 1:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 9:34 [PATCH v3 0/2] extcon: Remove the deprecated extcon functions Chanwoo Choi
2016-05-31 9:34 ` [PATCH v3 1/2] power: axp288_charger: Replace deprecatd API of extcon Chanwoo Choi
2016-06-09 1:18 ` Chanwoo Choi
2016-06-10 1:46 ` Sebastian Reichel
2016-06-10 1:51 ` Chanwoo Choi [this message]
2016-05-31 9:34 ` [PATCH v3 2/2] extcon: Remove the deprecated extcon functions Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575A1D2C.5060101@samsung.com \
--to=cw00.choi@samsung.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=sre@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).