From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Andy Yan <andy.yan@rock-chips.com>,
robh+dt@kernel.org, heiko@sntech.de, john.stultz@linaro.org,
arnd@arndb.de, bjorn.andersson@linaro.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
alexandre.belloni@free-electrons.com, dbaryshkov@gmail.com,
sre@kernel.org, matthias.bgg@gmail.com, linux-pm@vger.kernel.org,
mbrugger@suse.com, lorenzo.pieralisi@arm.com,
moritz.fischer@ettus.com, richard@nod.at
Subject: Re: [PATCH v9 2/4] power: reset: add reboot mode driver
Date: Mon, 20 Jun 2016 10:09:36 +0200 [thread overview]
Message-ID: <5767A4C0.3080902@samsung.com> (raw)
In-Reply-To: <1466404696-3464-1-git-send-email-andy.yan@rock-chips.com>
On 06/20/2016 08:38 AM, Andy Yan wrote:
> This driver parses the reboot commands like "reboot bootloader"
> and "reboot recovery" to get a boot mode described in the
> device tree , then call the write interfae to store the boot
> mode in some place like special register or sram, which can
> be read by the bootloader after system reboot, then the bootloader
> can take different action according to the mode stored.
>
> This is commonly used on Android based devices, in order to
> reboot the device into fastboot or recovery mode.
>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> Reviewed-by: Moritz Fischer <moritz.fischer@ettus.com>
> Tested-by: John Stultz <john.stultz@linaro.org>
> Acked-by: John Stultz <john.stultz@linaro.org>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>
> ---
>
> Changes in v9:
> - select MFD_SYSCON when syscon-reboot-mode driver enabled
> - refactoring error handling in reboot_mode_register
>
> Changes in v8:
> - do some cleanup when driver ubind
>
> Changes in v7:
> - address some suggestions from Krzysztof, make syscon-reboot-mode driver data self-contained.
>
> Changes in v6: None
> Changes in v5:
> - use two blank space under help in Kconfig
> - use unsigned int instead of int for member magic in struct mode_info
>
> Changes in v4:
> - make this driver depends on OF to avoid kbuild test error
>
> Changes in v3:
> - scan multi properities
> - add mask value for some platform which only use some bits of the register
> to store boot mode magic value
>
> Changes in v2:
> - move to dir drivers/power/reset/
> - make syscon-reboot-mode a generic driver
>
> Changes in v1:
> - fix the embarrassed compile warning
> - correct the maskrom magic number
> - check for the normal reboot
>
> drivers/power/reset/Kconfig | 14 ++++
> drivers/power/reset/Makefile | 2 +
> drivers/power/reset/reboot-mode.c | 128 +++++++++++++++++++++++++++++++
> drivers/power/reset/reboot-mode.h | 14 ++++
> drivers/power/reset/syscon-reboot-mode.c | 100 ++++++++++++++++++++++++
> 5 files changed, 258 insertions(+)
> create mode 100644 drivers/power/reset/reboot-mode.c
> create mode 100644 drivers/power/reset/reboot-mode.h
> create mode 100644 drivers/power/reset/syscon-reboot-mode.c
>
> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> index 9bb2622..4ceaf74 100644
> --- a/drivers/power/reset/Kconfig
> +++ b/drivers/power/reset/Kconfig
> @@ -183,5 +183,19 @@ config POWER_RESET_ZX
> help
> Reboot support for ZTE SoCs.
>
> +config REBOOT_MODE
> + tristate
> +
> +config SYSCON_REBOOT_MODE
> + bool "Generic SYSCON regmap reboot mode driver"
Why not tristate?
Beside that the patch looks good.
Best regards,
Krzysztof
> + depends on OF
> + select REBOOT_MODE
> + select MFD_SYSCON
> + help
> + Say y here will enable reboot mode driver. This will
> + get reboot mode arguments and store it in SYSCON mapped
> + register, then the bootloader can read it to take different
> + action according to the mode.
> +
next prev parent reply other threads:[~2016-06-20 8:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 6:34 [PATCH v9 0/4] add reboot mode driver Andy Yan
2016-06-20 6:36 ` [PATCH v9 1/4] dt-bindings: power: reset: add document for reboot-mode driver Andy Yan
2016-06-20 6:38 ` [PATCH v9 2/4] power: reset: add reboot mode driver Andy Yan
2016-06-20 8:09 ` Krzysztof Kozlowski [this message]
2016-06-20 8:28 ` Andy Yan
2016-06-20 12:31 ` Krzysztof Kozlowski
2016-06-20 14:40 ` Paul Gortmaker
2016-06-21 6:16 ` Andy Yan
[not found] ` <5768DBCB.4090903-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-06-21 9:32 ` Krzysztof Kozlowski
2016-07-06 13:39 ` Krzysztof Kozlowski
2016-06-20 6:39 ` [PATCH v9 3/4] ARM: dts: rockchip: add syscon-reboot-mode DT node Andy Yan
2016-06-20 21:55 ` Bjorn Andersson
2016-06-21 6:08 ` Andy Yan
2016-06-20 6:40 ` [PATCH v9 4/4] ARM64: " Andy Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5767A4C0.3080902@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=andy.yan@rock-chips.com \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mbrugger@suse.com \
--cc=moritz.fischer@ettus.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).