Re: [PATCH v9 3/4] ARM: dts: rockchip: add syscon-reboot-mode DT node

[Andy Yan <andy.yan@rock-chips.com>]

Hi Bjorn:
On 2016年06月21日 05:55, Bjorn Andersson wrote:
> On Sun 19 Jun 23:39 PDT 2016, Andy Yan wrote:
>
>> Rockchip platform use a SYSCON mapped register store
>> the reboot mode magic value for bootloader to use when
>> system reboot. So add syscon-reboot-mode driver DT node
>> for rk3xxx/rk3036/rk3288 based platform
>>
>> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>>
> [..]
>> diff --git a/include/dt-bindings/soc/rockchip_boot-mode.h b/include/dt-bindings/soc/rockchip_boot-mode.h
>> new file mode 100644
>> index 0000000..ae7c867
>> --- /dev/null
>> +++ b/include/dt-bindings/soc/rockchip_boot-mode.h
>> @@ -0,0 +1,15 @@
>> +#ifndef __ROCKCHIP_BOOT_MODE_H
>> +#define __ROCKCHIP_BOOT_MODE_H
>> +
>> +/*high 24 bits is tag, low 8 bits is type*/
>> +#define REBOOT_FLAG		0x5242C300
>> +/* normal boot */
>> +#define BOOT_NORMAL		(REBOOT_FLAG + 0)
>> +/* enter bootloader rockusb mode */
>> +#define BOOT_BL_DOWNLOAD	(REBOOT_FLAG + 1)
>> +/* enter recovery */
>> +#define BOOT_RECOVERY		(REBOOT_FLAG + 3)
>> + /* enter fastboot mode */
>> +#define BOOT_FASTBOOT		(REBOOT_FLAG + 9)
> The names of these defines are too generic for being in a header file.
> You should likely make them include "ROCKCHIP" and "BOOT_MODE".
>
> Regards,
> Bjorn
>
>
>
I have already named this file as rockchip_boot-mode.h, I thinks this is
enough to declare it. And I also check some header files like 
qcom,gsbi.h, thermal/theraml_exynos.h, they also don't have include some 
flag like QCOM or EXYNOS.