linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chanwoo Choi <cw00.choi@samsung.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>,
	linux-kernel@vger.kernel.org
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/5] PM / devfreq: make devfreq-event explicitly non-modular
Date: Mon, 27 Jun 2016 11:28:17 +0900	[thread overview]
Message-ID: <57708F41.6010201@samsung.com> (raw)
In-Reply-To: <20160625184351.5045-3-paul.gortmaker@windriver.com>

Hi Paul,

On 2016년 06월 26일 03:43, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
> 
> menuconfig PM_DEVFREQ_EVENT
> 	bool "DEVFREQ-Event device Support"
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> This code wasn't using module_init, so we don't need to be concerned
> with altering the initcall level here.
> 
> We don't replace module.h with init.h since the file already has that.
> But we do add export.h since this file does export some symbols.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
> 
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> Cc: linux-pm@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
>  drivers/devfreq/devfreq-event.c | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)

Acked-by: Chanwoo Choi <cw00.choi@samsung.com>

Regards,
Chanwoo Choi

  reply	other threads:[~2016-06-27  2:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-25 18:43 [PATCH v2 0/5] PM / devfreq: make module code usage consistent Paul Gortmaker
2016-06-25 18:43 ` [PATCH 1/5] PM / devfreq: make devfreq explicitly non-modular Paul Gortmaker
2016-06-27  2:27   ` Chanwoo Choi
2016-06-25 18:43 ` [PATCH 2/5] PM / devfreq: make devfreq-event " Paul Gortmaker
2016-06-27  2:28   ` Chanwoo Choi [this message]
2016-06-25 18:43 ` [PATCH 3/5] PM / devfreq: make exynos-bus ARM_EXYNOS_BUS_DEVFREQ tristate Paul Gortmaker
2016-06-27  2:28   ` Chanwoo Choi
2016-06-25 18:43 ` [PATCH 4/5] PM / devfreq: make event/exynos-nocp DEVFREQ_EVENT_EXYNOS_NOCP tristate Paul Gortmaker
2016-06-27  2:29   ` Chanwoo Choi
2016-06-25 18:43 ` [PATCH 5/5] PM / devfreq: make event/exynos-ppmu DEVFREQ_EVENT_EXYNOS_PPMU tristate Paul Gortmaker
2016-06-27  2:29   ` Chanwoo Choi
  -- strict thread matches above, loose matches on Subject: below --
2016-06-21  5:14 [PATCH 0/5] PM / devfreq: remove modular references from non-modules Paul Gortmaker
2016-06-21  5:14 ` [PATCH 2/5] PM / devfreq: make devfreq-event explicitly non-modular Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57708F41.6010201@samsung.com \
    --to=cw00.choi@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=paul.gortmaker@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).