From: Chanwoo Choi <cw00.choi@samsung.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>,
linux-kernel@vger.kernel.org
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 4/5] PM / devfreq: make event/exynos-nocp DEVFREQ_EVENT_EXYNOS_NOCP tristate
Date: Mon, 27 Jun 2016 11:29:14 +0900 [thread overview]
Message-ID: <57708F7A.70707@samsung.com> (raw)
In-Reply-To: <20160625184351.5045-5-paul.gortmaker@windriver.com>
Hi Paul,
On 2016년 06월 26일 03:43, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
>
> event/Kconfig:config DEVFREQ_EVENT_EXYNOS_NOCP
> event/Kconfig: bool "EXYNOS NoC (Network On Chip) Probe DEVFREQ event Driver"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Rather than rip out the existing modular code, Chanwoo indicated
> that he'd rather see the driver offered as tristate.
>
> I don't have the hardware for runtime validation, so this change
> is only validated for compile and modpost.
>
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: linux-pm@vger.kernel.org
> Cc: linux-samsung-soc@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
> drivers/devfreq/event/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/event/Kconfig b/drivers/devfreq/event/Kconfig
> index 1e8b4f469f38..96ea29d1ede5 100644
> --- a/drivers/devfreq/event/Kconfig
> +++ b/drivers/devfreq/event/Kconfig
> @@ -14,7 +14,7 @@ menuconfig PM_DEVFREQ_EVENT
> if PM_DEVFREQ_EVENT
>
> config DEVFREQ_EVENT_EXYNOS_NOCP
> - bool "EXYNOS NoC (Network On Chip) Probe DEVFREQ event Driver"
> + tristate "EXYNOS NoC (Network On Chip) Probe DEVFREQ event Driver"
> depends on ARCH_EXYNOS
> select PM_OPP
> help
>
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Regards,
Chanwoo Choi
next prev parent reply other threads:[~2016-06-27 2:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-25 18:43 [PATCH v2 0/5] PM / devfreq: make module code usage consistent Paul Gortmaker
2016-06-25 18:43 ` [PATCH 1/5] PM / devfreq: make devfreq explicitly non-modular Paul Gortmaker
2016-06-27 2:27 ` Chanwoo Choi
2016-06-25 18:43 ` [PATCH 2/5] PM / devfreq: make devfreq-event " Paul Gortmaker
2016-06-27 2:28 ` Chanwoo Choi
2016-06-25 18:43 ` [PATCH 3/5] PM / devfreq: make exynos-bus ARM_EXYNOS_BUS_DEVFREQ tristate Paul Gortmaker
2016-06-27 2:28 ` Chanwoo Choi
2016-06-25 18:43 ` [PATCH 4/5] PM / devfreq: make event/exynos-nocp DEVFREQ_EVENT_EXYNOS_NOCP tristate Paul Gortmaker
2016-06-27 2:29 ` Chanwoo Choi [this message]
2016-06-25 18:43 ` [PATCH 5/5] PM / devfreq: make event/exynos-ppmu DEVFREQ_EVENT_EXYNOS_PPMU tristate Paul Gortmaker
2016-06-27 2:29 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57708F7A.70707@samsung.com \
--to=cw00.choi@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).