From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH] PM-wakeup: Delete unnecessary checks before two function calls Date: Fri, 22 Jul 2016 23:52:56 +0200 Message-ID: <5786434.e97HVzPjpI@vostro.rjw.lan> References: <5307CAA2.8060406@users.sourceforge.net> <558FCAC1.1090605@users.sourceforge.net> <427a7f9d-d1c2-10be-9a23-30350ced6149@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <427a7f9d-d1c2-10be-9a23-30350ced6149@users.sourceforge.net> Sender: linux-kernel-owner@vger.kernel.org To: SF Markus Elfring Cc: Greg Kroah-Hartman , Len Brown , Pavel Machek , linux-pm@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall List-Id: linux-pm@vger.kernel.org On Friday, July 22, 2016 10:35:27 PM SF Markus Elfring wrote: > Am 28.06.2015 um 12:21 schrieb SF Markus Elfring: > > From: Markus Elfring > > Date: Sun, 28 Jun 2015 12:14:43 +0200 > > > > The functions dev_pm_disarm_wake_irq() and wakeup_source_unregister() test > > whether their argument is NULL and then return immediately. > > Thus the test around the calls is not needed. > > > > This issue was detected by using the Coccinelle software. > > > > Signed-off-by: Markus Elfring > > --- > > drivers/base/power/wakeup.c | 10 +++------- > > 1 file changed, 3 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c > > index 40f7160..3741bc2 100644 > > --- a/drivers/base/power/wakeup.c > > +++ b/drivers/base/power/wakeup.c > > @@ -341,8 +341,7 @@ void device_wakeup_arm_wake_irqs(void) > > > > rcu_read_lock(); > > list_for_each_entry_rcu(ws, &wakeup_sources, entry) { > > - if (ws->wakeirq) > > - dev_pm_arm_wake_irq(ws->wakeirq); > > + dev_pm_arm_wake_irq(ws->wakeirq); > > } > > rcu_read_unlock(); > > } > > @@ -358,8 +357,7 @@ void device_wakeup_disarm_wake_irqs(void) > > > > rcu_read_lock(); > > list_for_each_entry_rcu(ws, &wakeup_sources, entry) { > > - if (ws->wakeirq) > > - dev_pm_disarm_wake_irq(ws->wakeirq); > > + dev_pm_disarm_wake_irq(ws->wakeirq); > > } > > rcu_read_unlock(); > > } > > @@ -396,9 +394,7 @@ int device_wakeup_disable(struct device *dev) > > return -EINVAL; > > > > ws = device_wakeup_detach(dev); > > - if (ws) > > - wakeup_source_unregister(ws); > > - > > + wakeup_source_unregister(ws); > > return 0; > > } > > EXPORT_SYMBOL_GPL(device_wakeup_disable); > > > > How do you think about to integrate this update suggestion > into another source code repository? I'm not really sure what you mean. Thanks, Rafael