From: Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
To: Lin Huang <hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
"\"함명주 (samsung.com)\""
<myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] PM / devfreq: event: remove duplicate devfreq_event_get_drvdata()
Date: Thu, 04 Aug 2016 17:40:05 +0900 [thread overview]
Message-ID: <57A2FF65.80704@samsung.com> (raw)
In-Reply-To: <1470290508-19178-1-git-send-email-hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
+ Myungjoo Ham,
Hi Lin Huang,
On 2016년 08월 04일 15:01, Lin Huang wrote:
> there define two devfreq_event_get_drvdata() function in devfreq-event.h
> when disable CONFIG_PM_DEVFREQ_EVENT, it will lead to build fail. So
> remove devfreq_event_get_drvdata() function.
>
> Signed-off-by: Lin Huang <hl@rock-chips.com>
> ---
> include/linux/devfreq-event.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/include/linux/devfreq-event.h b/include/linux/devfreq-event.h
> index 0a83a1e..4db00b0 100644
> --- a/include/linux/devfreq-event.h
> +++ b/include/linux/devfreq-event.h
> @@ -148,11 +148,6 @@ static inline int devfreq_event_reset_event(struct devfreq_event_dev *edev)
> return -EINVAL;
> }
>
> -static inline void *devfreq_event_get_drvdata(struct devfreq_event_dev *edev)
> -{
> - return ERR_PTR(-EINVAL);
> -}
> -
> static inline struct devfreq_event_dev *devfreq_event_get_edev_by_phandle(
> struct device *dev, int index)
> {
>
Looks good to me.
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Regards,
Chanwoo Choi
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2016-08-04 8:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20160804060219epcas1p2543bf871e76403f90d47f352251074fa@epcas1p2.samsung.com>
2016-08-04 6:01 ` [PATCH] PM / devfreq: event: remove duplicate devfreq_event_get_drvdata() Lin Huang
[not found] ` <1470290508-19178-1-git-send-email-hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-08-04 8:40 ` Chanwoo Choi [this message]
[not found] <CGME20160804102847epcas1p498c32c32d5aaec87e607ff4adb07070a@epcas1p4.samsung.com>
2016-08-04 10:28 ` Chanwoo Choi
2016-08-04 10:30 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57A2FF65.80704@samsung.com \
--to=cw00.choi-sze3o3uu22jbdgjk7y7tuq@public.gmane.org \
--cc=hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).