* [PATCH] PM / devfreq: event: remove duplicate devfreq_event_get_drvdata()
@ 2016-08-04 6:01 ` Lin Huang
[not found] ` <1470290508-19178-1-git-send-email-hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Lin Huang @ 2016-08-04 6:01 UTC (permalink / raw)
To: cw00.choi; +Cc: linux-pm, linux-kernel, linux-rockchip, Lin Huang
there define two devfreq_event_get_drvdata() function in devfreq-event.h
when disable CONFIG_PM_DEVFREQ_EVENT, it will lead to build fail. So
remove devfreq_event_get_drvdata() function.
Signed-off-by: Lin Huang <hl@rock-chips.com>
---
include/linux/devfreq-event.h | 5 -----
1 file changed, 5 deletions(-)
diff --git a/include/linux/devfreq-event.h b/include/linux/devfreq-event.h
index 0a83a1e..4db00b0 100644
--- a/include/linux/devfreq-event.h
+++ b/include/linux/devfreq-event.h
@@ -148,11 +148,6 @@ static inline int devfreq_event_reset_event(struct devfreq_event_dev *edev)
return -EINVAL;
}
-static inline void *devfreq_event_get_drvdata(struct devfreq_event_dev *edev)
-{
- return ERR_PTR(-EINVAL);
-}
-
static inline struct devfreq_event_dev *devfreq_event_get_edev_by_phandle(
struct device *dev, int index)
{
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] PM / devfreq: event: remove duplicate devfreq_event_get_drvdata()
[not found] ` <1470290508-19178-1-git-send-email-hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
@ 2016-08-04 8:40 ` Chanwoo Choi
0 siblings, 0 replies; 4+ messages in thread
From: Chanwoo Choi @ 2016-08-04 8:40 UTC (permalink / raw)
To: Lin Huang
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
"함명주 (samsung.com)",
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-pm-u79uwXL29TY76Z2rM5mHXA
+ Myungjoo Ham,
Hi Lin Huang,
On 2016년 08월 04일 15:01, Lin Huang wrote:
> there define two devfreq_event_get_drvdata() function in devfreq-event.h
> when disable CONFIG_PM_DEVFREQ_EVENT, it will lead to build fail. So
> remove devfreq_event_get_drvdata() function.
>
> Signed-off-by: Lin Huang <hl@rock-chips.com>
> ---
> include/linux/devfreq-event.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/include/linux/devfreq-event.h b/include/linux/devfreq-event.h
> index 0a83a1e..4db00b0 100644
> --- a/include/linux/devfreq-event.h
> +++ b/include/linux/devfreq-event.h
> @@ -148,11 +148,6 @@ static inline int devfreq_event_reset_event(struct devfreq_event_dev *edev)
> return -EINVAL;
> }
>
> -static inline void *devfreq_event_get_drvdata(struct devfreq_event_dev *edev)
> -{
> - return ERR_PTR(-EINVAL);
> -}
> -
> static inline struct devfreq_event_dev *devfreq_event_get_edev_by_phandle(
> struct device *dev, int index)
> {
>
Looks good to me.
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Regards,
Chanwoo Choi
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] PM / devfreq: event: remove duplicate devfreq_event_get_drvdata()
@ 2016-08-04 10:28 ` Chanwoo Choi
2016-08-04 10:30 ` Chanwoo Choi
0 siblings, 1 reply; 4+ messages in thread
From: Chanwoo Choi @ 2016-08-04 10:28 UTC (permalink / raw)
To: linux-pm; +Cc: myungjoo.ham, kyungmin.park, linux-kernel, Lin Huang,
Chanwoo Choi
From: Lin Huang <hl@rock-chips.com>
there define two devfreq_event_get_drvdata() function in devfreq-event.h
when disable CONFIG_PM_DEVFREQ_EVENT, it will lead to build fail. So
remove devfreq_event_get_drvdata() function.
Fixes: f262f28c1470 ("PM / devfreq: event: Add devfreq_event class")
Signed-off-by: Lin Huang <hl@rock-chips.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
include/linux/devfreq-event.h | 5 -----
1 file changed, 5 deletions(-)
diff --git a/include/linux/devfreq-event.h b/include/linux/devfreq-event.h
index 0a83a1e648b0..4db00b02ca3f 100644
--- a/include/linux/devfreq-event.h
+++ b/include/linux/devfreq-event.h
@@ -148,11 +148,6 @@ static inline int devfreq_event_reset_event(struct devfreq_event_dev *edev)
return -EINVAL;
}
-static inline void *devfreq_event_get_drvdata(struct devfreq_event_dev *edev)
-{
- return ERR_PTR(-EINVAL);
-}
-
static inline struct devfreq_event_dev *devfreq_event_get_edev_by_phandle(
struct device *dev, int index)
{
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] PM / devfreq: event: remove duplicate devfreq_event_get_drvdata()
2016-08-04 10:28 ` Chanwoo Choi
@ 2016-08-04 10:30 ` Chanwoo Choi
0 siblings, 0 replies; 4+ messages in thread
From: Chanwoo Choi @ 2016-08-04 10:30 UTC (permalink / raw)
To: linux-pm; +Cc: myungjoo.ham, kyungmin.park, linux-kernel, Lin Huang
Dear all,
Please ignore this patch. This patch fix the bug.
So, I should send it on stable@verger.kernel.org.
But the stable mailing list is missing. So, I'll resend it.
Regards,
Chanwoo Choi
On 2016년 08월 04일 19:28, Chanwoo Choi wrote:
> From: Lin Huang <hl@rock-chips.com>
>
> there define two devfreq_event_get_drvdata() function in devfreq-event.h
> when disable CONFIG_PM_DEVFREQ_EVENT, it will lead to build fail. So
> remove devfreq_event_get_drvdata() function.
>
> Fixes: f262f28c1470 ("PM / devfreq: event: Add devfreq_event class")
> Signed-off-by: Lin Huang <hl@rock-chips.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
> include/linux/devfreq-event.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/include/linux/devfreq-event.h b/include/linux/devfreq-event.h
> index 0a83a1e648b0..4db00b02ca3f 100644
> --- a/include/linux/devfreq-event.h
> +++ b/include/linux/devfreq-event.h
> @@ -148,11 +148,6 @@ static inline int devfreq_event_reset_event(struct devfreq_event_dev *edev)
> return -EINVAL;
> }
>
> -static inline void *devfreq_event_get_drvdata(struct devfreq_event_dev *edev)
> -{
> - return ERR_PTR(-EINVAL);
> -}
> -
> static inline struct devfreq_event_dev *devfreq_event_get_edev_by_phandle(
> struct device *dev, int index)
> {
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-04 10:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20160804060219epcas1p2543bf871e76403f90d47f352251074fa@epcas1p2.samsung.com>
2016-08-04 6:01 ` [PATCH] PM / devfreq: event: remove duplicate devfreq_event_get_drvdata() Lin Huang
[not found] ` <1470290508-19178-1-git-send-email-hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-08-04 8:40 ` Chanwoo Choi
[not found] <CGME20160804102847epcas1p498c32c32d5aaec87e607ff4adb07070a@epcas1p4.samsung.com>
2016-08-04 10:28 ` Chanwoo Choi
2016-08-04 10:30 ` Chanwoo Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).