Re: [PATCH 2/4] cpu: expose pm_qos_resume_latency for each cpu

[Alex Shi <alex.shi@linaro.org>]

>> @@ -376,6 +377,8 @@ int register_cpu(struct cpu *cpu, int num)
>>  
>>  	per_cpu(cpu_sys_devices, num) = &cpu->dev;
>>  	register_cpu_under_node(num, cpu_to_node(num));
>> +	if (dev_pm_qos_expose_latency_limit(&cpu->dev, 0))
>> +		pr_debug("CPU%d: add resume latency failed\n", num);
> 
> Why is this a debug message?  And you have a struct device, why not use
> it?
> 

Looks no one care about the dev_pm_qos_expose_latency_limit's return
value, so this debug message like gilding the lily. will remove it.

> Also, what userspace changes does this require, or affect?  Any new
> sysfs files?

User can set values on each of cpu, like limit 100ms on cpu0, that means
the cpu0 response time should be in 100ms in possible idle. It similar
with DMA_LATENCY, but that request is for all cpu. This is just for
particular cpu, like a interrupt pined CPU.

echo 100 > /sys/devices/system/cpu/cpu0/power/pm_qos_resume_latency_us
> 
> thanks,
> 
> greg k-h
>