From: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
To: Chanwoo Choi <cw00.choi@samsung.com>, linux-samsung-soc@vger.kernel.org
Cc: linux-pm@vger.kernel.org, m.reichl@fivetechno.de, myungjoo.ham@gmail.com
Subject: Re: [RFC 4/4] ARM: dts: exynos4x12: add suspend OPP for DMC and leftbus
Date: Thu, 24 Nov 2016 15:27:18 +0100 [thread overview]
Message-ID: <5836F8C6.4080708@math.uni-bielefeld.de> (raw)
In-Reply-To: <58364560.4030904@samsung.com>
Hello Chanwoo,
since exynos-bus is not only used for the Exynos4 platform, could you
maybe check if we need to apply this elsewhere?
I see in the exynos5422-odroidxu3-common.dtsi that bus_wcore adjusts the
INT voltage. But MyungJoo mentioned that on newer platform the BL0 might
be "smarter", so we don't need this.
With best wishes,
Tobias
Chanwoo Choi wrote:
> Hi Tobias,
>
> Looks good to me.
> Because the bus_dmc (MIF) and bus_leftbus (INT) are parent devfreq device.
>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>
> Best Regards,
> Chanwoo Choi
>
> On 2016년 11월 23일 22:51, Tobias Jakobi wrote:
>> TODO: write desc
>> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
>> ---
>> arch/arm/boot/dts/exynos4x12.dtsi | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
>> index d5cb433..a00a8b0 100644
>> --- a/arch/arm/boot/dts/exynos4x12.dtsi
>> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
>> @@ -375,6 +375,7 @@
>> opp@400000000 {
>> opp-hz = /bits/ 64 <400000000>;
>> opp-microvolt = <1050000>;
>> + opp-suspend;
>> };
>> };
>>
>> @@ -463,6 +464,7 @@
>> opp@200000000 {
>> opp-hz = /bits/ 64 <200000000>;
>> opp-microvolt = <1000000>;
>> + opp-suspend;
>> };
>> };
>>
>>
>
next prev parent reply other threads:[~2016-11-24 14:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 13:51 [RFC 0/4] PM / devfreq: draft for OPP suspend impl Tobias Jakobi
2016-11-23 13:51 ` [RFC 1/4] PM / devfreq: Add DevFreq subsystem suspend/resume Tobias Jakobi
2016-11-24 1:34 ` Chanwoo Choi
2016-11-24 8:20 ` Chanwoo Choi
2016-11-24 14:20 ` Tobias Jakobi
2016-11-23 13:51 ` [RFC 2/4] PM / devfreq: suspend subsystem on system suspend/hibernate Tobias Jakobi
2016-11-24 1:35 ` Chanwoo Choi
2016-11-23 13:51 ` [RFC 3/4] PM / devfreq: exynos-bus: add support for suspend OPP Tobias Jakobi
2016-11-24 1:38 ` Chanwoo Choi
2016-11-24 14:22 ` Tobias Jakobi
2016-11-23 13:51 ` [RFC 4/4] ARM: dts: exynos4x12: add suspend OPP for DMC and leftbus Tobias Jakobi
2016-11-24 1:41 ` Chanwoo Choi
2016-11-24 14:27 ` Tobias Jakobi [this message]
2016-11-24 23:44 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5836F8C6.4080708@math.uni-bielefeld.de \
--to=tjakobi@math.uni-bielefeld.de \
--cc=cw00.choi@samsung.com \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.reichl@fivetechno.de \
--cc=myungjoo.ham@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).