* [PATCH] devfreq: rk3399_dmc: Remove dangling rcu_read_unlock()
@ 2016-12-01 10:42 ` Viresh Kumar
2016-12-02 8:43 ` Chanwoo Choi
0 siblings, 1 reply; 2+ messages in thread
From: Viresh Kumar @ 2016-12-01 10:42 UTC (permalink / raw)
To: Rafael Wysocki, MyungJoo Ham, Kyungmin Park
Cc: linaro-kernel, linux-pm, Stephen Boyd, nm, Vincent Guittot,
Viresh Kumar
This call never had the rcu_read_lock() counterpart. Remove the unlock
part as well.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/devfreq/rk3399_dmc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c
index 192240423fee..4cc5be08720a 100644
--- a/drivers/devfreq/rk3399_dmc.c
+++ b/drivers/devfreq/rk3399_dmc.c
@@ -408,7 +408,6 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev)
*/
if (dev_pm_opp_of_add_table(dev)) {
dev_err(dev, "Invalid operating-points in device tree.\n");
- rcu_read_unlock();
return -EINVAL;
}
--
2.7.1.410.g6faf27b
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] devfreq: rk3399_dmc: Remove dangling rcu_read_unlock()
2016-12-01 10:42 ` [PATCH] devfreq: rk3399_dmc: Remove dangling rcu_read_unlock() Viresh Kumar
@ 2016-12-02 8:43 ` Chanwoo Choi
0 siblings, 0 replies; 2+ messages in thread
From: Chanwoo Choi @ 2016-12-02 8:43 UTC (permalink / raw)
To: Viresh Kumar, Rafael Wysocki, MyungJoo Ham, Kyungmin Park
Cc: linaro-kernel, linux-pm, Stephen Boyd, nm, Vincent Guittot
Hi Viresh,
On 2016년 12월 01일 19:42, Viresh Kumar wrote:
> This call never had the rcu_read_lock() counterpart. Remove the unlock
> part as well.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/devfreq/rk3399_dmc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c
> index 192240423fee..4cc5be08720a 100644
> --- a/drivers/devfreq/rk3399_dmc.c
> +++ b/drivers/devfreq/rk3399_dmc.c
> @@ -408,7 +408,6 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev)
> */
> if (dev_pm_opp_of_add_table(dev)) {
> dev_err(dev, "Invalid operating-points in device tree.\n");
> - rcu_read_unlock();
> return -EINVAL;
> }
>
>
Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-02 8:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20161201104229epcas5p19eecb1b4fd77eef05ad8b4ee02f3267b@epcas5p1.samsung.com>
2016-12-01 10:42 ` [PATCH] devfreq: rk3399_dmc: Remove dangling rcu_read_unlock() Viresh Kumar
2016-12-02 8:43 ` Chanwoo Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).