From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34A683F44EF for ; Wed, 19 Aug 2026 08:37:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787128677; cv=none; b=VNUA/auXSsUnhyRb0aRCNZfHOobxqQ2wyQleGQ8E+Ykzn0Z3qBOVi7UihMT00UcNVM8ShXw0RJKb4qJhvADS5HdkArW9NaAjE//z9ICnqUa2cMgYjexihruCwuGuheV0oUX4f2dlTPgHLR0T98+02m/4pd8BZqmjltf8D/5MApc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787128677; c=relaxed/simple; bh=J8OvenS2hCs5THMJYtmCxf16EEHr+bum+fX8PSaJgqY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WTw4CnhuK2BmxFwp1xxFHggJ1LTHIghKEhFLsa20MCmd7y0A7W0v3YPFS60Ff61Fz0Q/vKJTROxBoE5NL2ERWP/K/gwfMn/XpVlB8BVLkmx0FVTcjzqtcc+ewHBF6mZ+eK28U1bP/W9pnQzJBCbjLjyGzp3iKhDqxGHEd9MLGwM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ak616cRj; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ak616cRj" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-c20e70a0962so97800966b.2 for ; Wed, 19 Aug 2026 01:37:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787128674; x=1787733474; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OWyG58LZRk0FpypFIgr97MJusUzcaJB4SA6RQG40M3M=; b=Ak616cRjhRj8soNDK7wk18/0mrwuHmdnqpxX9rrWLfhizs9Iqf4aYqJbi6lgW3v1RW BV65ktICdj4HQYf8U4oDZnXSCvPtQyEUdxbr8WuDAZ1kMo6lP+laox5xnAFgKppfUWvm 1kRQ9oMBpOFimzkWqsEbddmOlvbwpm+b5/ftM7Gke4OnGpSvzYYGJ0MroM/bOsJilYRc 6zNsJus2INwTfkMb7hKoy5Lwdckmhn8y5dghJhWU00EYEkavTQVsbvMahvvLP0uTm3RO NpfT43vvnK12MTUqQGurkY+9Bzi/+SlAOnVsYpuoXUUlOsuHVudpqdf7DzcQR6NTjJsF g9tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787128674; x=1787733474; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OWyG58LZRk0FpypFIgr97MJusUzcaJB4SA6RQG40M3M=; b=Vd4ZI3lIq3HDh+DeudzT1wem10ztwShtxnM+d8IJnGNOFRfkAgw7VdnUv951vLYH6v k0oZC4mKVfAfw6M0C9HqhaGkZ7u8w2G0VfYp98W9zSef1Qh0tpW3CqhPxImSrsGVq8ia 9hRn4RnN9/EdU+Whto/EshbtpD2FiUC3Jkju8w3XkhBKNZavcYBLMNHYQbJYpFLXBVF2 PkTrwR782jZBztTdlTCZCUswxMc0FgtPEqG/jxI/+3mYuGR50AzzHXko4IoeMvCp+JZd qudmt7+haMqKFypqaoD2OGlVSungZz5V59Mgznf8Jith8YViQ7SIX9D7bm56CVq9OmQk OPuw== X-Forwarded-Encrypted: i=1; AHgh+RpwZuZrpwbRXr3lsGWTjaAIq+X3mXoM3oIPo4+c+3+On++vvS7299YqYzcgUJuLS6VpemehyNL6QQ==@vger.kernel.org X-Gm-Message-State: AOJu0YzZUGOZaCLmFu92rN2Nv220MlJICZGDpsEV23rDepA5fqmgngXf aUCNtmkmTVZaxS4gBf4rBTakQY1WxVMVoS16S/ZbHWwvp7MxNp/ZdUvs X-Gm-Gg: AR+sD117bpG7dOFj1x22HXI7PSrb81PTLpw8ljjRyJX1r/onq3Uaa09wmpjHfw1+Lnr oNrFg1qvWUikZnBPE/unKbbineHTuqL/jGu55i2mUMcsUbcuJx8axEMAyR6sWL2y8jdy+WD74a1 9vSGVo5LKlVtia3UqtUbl5D+EQtEmT6Zs/0zwx2jC3EKKJXpGiMTJlzWmCbm9+IgFd+7YAQqf3i sOUE6DdfI9yE05m6hfllHnynBSZ1bUxe3gi4XR1R2I+7mpW5vJ+9DDsBcLu7J5HynkiTZLPTY4K +DU6Lgfwkkizqik5LAhgkH9Y28TUmTtR5xrch7N/s9sWcR8T5iBwxTqb3XW04Sl9uHJQy8TzEBI nB66C1S3wTHho35SZIswJLA4D0L2vGBpqfWXkysynB8QJ/FxaGK1eBp9Y+s0m9VaLHZj+S98Nd/ pmhUP/Q/LbhZULZ7xk/Q9LW1dWMVkAO3YeCLLJ44KvRhu8774ybmTbwUKuluP4zolUyMEpab8SG KHjqcz6lD1zM3bxzrird75OpA== X-Received: by 2002:a17:907:3e1e:b0:c15:fc59:cdf3 with SMTP id a640c23a62f3a-c242e206084mr165876966b.12.1787128674163; Wed, 19 Aug 2026 01:37:54 -0700 (PDT) Received: from [192.168.1.30] (161-53-210-87.ftth.glasoperator.nl. [87.210.53.161]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c243c38b379sm43248966b.39.2026.08.19.01.37.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Aug 2026 01:37:53 -0700 (PDT) Message-ID: <590e7881-de96-4de4-bb50-1e91439b92ef@gmail.com> Date: Wed, 19 Aug 2026 10:37:53 +0200 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] power: supply: qcom_battmgr: add Xiaomi taoyao support To: Krzysztof Kozlowski Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org References: <20260818151039.409767-1-zstaseg@gmail.com> <20260818151039.409767-3-zstaseg@gmail.com> <20260819-slick-spotted-chamois-962510@quoll> Content-Language: en-US From: Stanislav Zaikin In-Reply-To: <20260819-slick-spotted-chamois-962510@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/19/26 9:11 AM, Krzysztof Kozlowski wrote: > On Tue, Aug 18, 2026 at 05:10:38PM +0200, user.email wrote: >> From: Stanislav Zaikin >> >> The Xiaomi taoyao firmware defines an additional BATT_CONSTANT_CURRENT >> property (ID 12) between BATT_CHG_CTRL_LIM_MAX and BATT_TEMP, shifting >> all higher battery property IDs by one. >> >> Signed-off-by: Stanislav Zaikin >> --- >> drivers/power/supply/qcom_battmgr.c | 86 +++++++++++++++++++++++++++-- >> 1 file changed, 82 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/power/supply/qcom_battmgr.c b/drivers/power/supply/qcom_battmgr.c >> index 490137a23d00..390d7c75e36f 100644 >> --- a/drivers/power/supply/qcom_battmgr.c >> +++ b/drivers/power/supply/qcom_battmgr.c >> @@ -24,6 +24,7 @@ enum qcom_battmgr_variant { >> QCOM_BATTMGR_SM8350, >> QCOM_BATTMGR_SM8550, >> QCOM_BATTMGR_X1E80100, >> + QCOM_BATTMGR_TAOYAO, > > T < X, do not introduce entries in random order Hello Krzysztof, Thank you for the review. Will fix in v3. >> @@ -1381,6 +1453,11 @@ static void qcom_battmgr_sm8350_callback(struct qcom_battmgr *battmgr, >> switch (opcode) { >> case BATTMGR_BAT_PROPERTY_GET: >> property = le32_to_cpu(resp->intval.property); >> + >> + if (battmgr->variant == QCOM_BATTMGR_TAOYAO && >> + property < ARRAY_SIZE(taoyao_to_canonical)) >> + property = taoyao_to_canonical[property]; > > So device is or is not compatible with sm7325? Above code suggests that > it is not. How does it work when bound by sm7325 compatible? The device is sm7325-based and when bound to sm7325-pmic-glink it falls back to QCOM_BATTMGR_SM8350 property map. However, due to shifted property IDs baked into taoyao's firmware the parsing of roughly the 2nd half of properties is broken. And any userspace process that reads the battery properties via sysfs suffers from 1s timeouts and it basically hangs my DE. Since this is an RFC: do you think this approach is better than what I described in cover letter? (manually shifting property IDs) >> @@ -1617,6 +1694,7 @@ static const struct of_device_id qcom_battmgr_of_variants[] = { >> { .compatible = "qcom,sc8280xp-pmic-glink", .data = (void *)QCOM_BATTMGR_SC8280XP }, >> { .compatible = "qcom,sm8550-pmic-glink", .data = (void *)QCOM_BATTMGR_SM8550 }, >> { .compatible = "qcom,x1e80100-pmic-glink", .data = (void *)QCOM_BATTMGR_X1E80100 }, >> + { .compatible = "xiaomi,taoyao-pmic-glink", .data = (void *)QCOM_BATTMGR_TAOYAO }, > > And here as well wrong order Will fix in v3. -- Best regards, Stanislav